From 814efeeee9de63dc602c8c8f45e32ca2871474d7 Mon Sep 17 00:00:00 2001 From: Sergey Evdokimov Date: Sun, 26 Feb 2012 16:33:35 +0400 Subject: [PATCH] IDEA-81486 (IDEA complains about "stable" snapshot dependencies) Don't highlight stable snapshot dependencies red. --- .../MavenArtifactCoordinatesVersionConverter.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/converters/MavenArtifactCoordinatesVersionConverter.java b/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/converters/MavenArtifactCoordinatesVersionConverter.java index b7afdd34061a..ceec59f41e39 100644 --- a/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/converters/MavenArtifactCoordinatesVersionConverter.java +++ b/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/converters/MavenArtifactCoordinatesVersionConverter.java @@ -22,8 +22,12 @@ import org.jetbrains.idea.maven.model.MavenId; import java.util.Collections; import java.util.Set; +import java.util.regex.Pattern; public class MavenArtifactCoordinatesVersionConverter extends MavenArtifactCoordinatesConverter { + + private static final Pattern MAGIC_VERSION_PATTERN = Pattern.compile("\\s*(?:LATEST|RELEASE|[(\\[].*|.*-20\\d{6}\\.[0-2]\\d{5}-\\d+)\\s*"); + @Override protected boolean doIsValid(MavenId id, MavenProjectIndicesManager manager, ConvertContext context) { if (StringUtil.isEmpty(id.getGroupId()) @@ -31,15 +35,10 @@ public class MavenArtifactCoordinatesVersionConverter extends MavenArtifactCoord || StringUtil.isEmpty(id.getVersion())) { return false; } - if (isMagicVersion(id)) return true; // todo handle ranges more sensibly + if (MAGIC_VERSION_PATTERN.matcher(id.getVersion()).matches()) return true; // todo handle ranges more sensibly return manager.hasVersion(id.getGroupId(), id.getArtifactId(), id.getVersion()); } - private boolean isMagicVersion(MavenId id) { - String version = id.getVersion().trim(); - return version.equals("LATEST") || version.equals("RELEASE") || version.startsWith("(") || version.startsWith("["); - } - @Override protected Set doGetVariants(MavenId id, MavenProjectIndicesManager manager) { if (StringUtil.isEmpty(id.getGroupId()) || StringUtil.isEmpty(id.getArtifactId())) return Collections.emptySet();