From 7f5db28b38784e5f67c3a4ad2db16d05c48ec05c Mon Sep 17 00:00:00 2001 From: Alexey Kudravtsev Date: Fri, 20 Nov 2009 17:42:31 +0300 Subject: [PATCH] more correct comprasion --- .../codeInsight/daemon/impl/quickfix/ExtendsListFix.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ExtendsListFix.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ExtendsListFix.java index 29e314911328..48b579f2435b 100644 --- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ExtendsListFix.java +++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ExtendsListFix.java @@ -37,14 +37,14 @@ public class ExtendsListFix implements IntentionAction, LocalQuickFix { private final boolean myToAdd; private final PsiClassType myTypeToExtendFrom; - public ExtendsListFix(PsiClass aClass, PsiClassType typeToExtendFrom, boolean toAdd) { + public ExtendsListFix(@NotNull PsiClass aClass, @NotNull PsiClassType typeToExtendFrom, boolean toAdd) { myClass = aClass; myClassToExtendFrom = typeToExtendFrom.resolve(); myTypeToExtendFrom = typeToExtendFrom; myToAdd = toAdd; } - public ExtendsListFix(PsiClass aClass, PsiClass classToExtendFrom, boolean toAdd) { + public ExtendsListFix(@NotNull PsiClass aClass, @NotNull PsiClass classToExtendFrom, boolean toAdd) { myClass = aClass; myClassToExtendFrom = classToExtendFrom; myTypeToExtendFrom = JavaPsiFacade.getInstance(aClass.getProject()).getElementFactory().createType(classToExtendFrom); @@ -126,7 +126,7 @@ public class ExtendsListFix implements IntentionAction, LocalQuickFix { PsiJavaCodeReferenceElement[] referenceElements = extendsList.getReferenceElements(); boolean alreadyExtends = false; for (PsiJavaCodeReferenceElement referenceElement : referenceElements) { - if (referenceElement.resolve() == myClassToExtendFrom) { + if (referenceElement.getManager().areElementsEquivalent(myClassToExtendFrom, referenceElement.resolve())) { alreadyExtends = true; if (!add) { referenceElement.delete();