From 7d59ffde38d6b63ace7b21fc2b91be7e9a3d4bd2 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Wed, 13 May 2020 15:04:08 +0700 Subject: [PATCH] Fixed unnecessarily escaped character GitOrigin-RevId: 9532833be54e94cfe74dee90f4ca815790d7f5be --- .../ui/tree/render/PrimitiveRenderer.java | 2 +- .../ModuleNameLocationComponent.java | 2 +- .../modes/CreateModuleFromSourcesMode.java | 4 ++-- .../quickfix/QualifyThisOrSuperArgumentFix.java | 2 +- .../CodeStyleGenerationConfigurable.java | 2 +- .../impl/quickfix/PullAsAbstractUpFix.java | 8 ++++---- .../StringLiteralCopyPasteProcessor.java | 2 +- .../editorActions/smartEnter/LiteralFixer.java | 2 +- .../extractclass/ExtractClassDialog.java | 4 ++-- .../extractclass/ExtractClassProcessor.java | 4 ++-- .../InheritanceToDelegationDialog.java | 4 ++-- .../InlineSuperClassRefactoringProcessor.java | 2 +- .../usageInfo/ReplaceWithSubtypeUsageInfo.java | 6 +++--- .../IntroduceParameterDialog.java | 2 +- .../IntroduceParameterObjectDialog.java | 14 ++++++++------ .../usageInfo/AppendAccessorsUsageInfo.java | 2 +- .../JavaMoveClassesOrPackagesHandler.java | 4 ++-- .../rename/RenamePsiPackageProcessor.java | 2 +- .../ReplaceConstructorWithBuilderDialog.java | 17 +++++++++++------ .../ReplaceConstructorWithFactoryDialog.java | 2 +- .../typeMigration/ui/TypeMigrationDialog.java | 4 ++-- .../wrapreturnvalue/WrapReturnValueDialog.java | 10 +++++----- .../highlighter/custom/CustomFileTypeLexer.java | 2 +- .../intellij/psi/impl/source/CharTableImpl.java | 2 +- .../generation/CommentByLineCommentHandler.java | 2 +- .../actions/CodeInspectionAction.java | 2 +- .../ide/util/gotoByName/ChooseByNameBase.java | 2 +- .../actions/ModuleDeleteProvider.java | 2 +- .../templates/TemplateModuleBuilder.java | 2 +- .../psi/search/DefaultSearchScopeProviders.java | 2 +- .../rename/AutomaticRenamingDialog.java | 2 +- .../com/intellij/execution/CommandLineUtil.java | 2 +- .../LengthOneStringInIndexOfInspection.java | 2 +- .../siyeh/ig/junit/MakePublicStaticVoidFix.java | 6 +++--- ...zedParametersStaticCollectionInspection.java | 4 ++-- .../copyright/ui/CopyrightProfilesPanel.java | 2 +- .../TestDataGuessByExistingFilesUtil.java | 2 +- .../config/EclipseClasspathStorageProvider.java | 12 ++++++------ .../idea/eclipse/conversion/EPathUtil.java | 2 +- .../commands/GitHttpGuiAuthenticator.java | 2 +- .../DefaultUnresolvedExternalDependency.java | 2 +- .../ConvertStringToMultilineIntention.java | 2 +- .../modules/decompiler/exps/ConstExprent.java | 2 +- .../JavaFxBuiltInAttributeDescriptor.java | 2 +- .../descriptors/JavaFxBuiltInTagDescriptor.java | 2 +- .../intellij/execution/junit/TestDirectory.java | 2 +- .../intellij/junit3/JUnit3IdeaTestRunner.java | 14 +++++++------- .../maven/server/MavenEffectivePomDumper.java | 2 +- .../editor/PropertiesCopyHandler.java | 2 +- .../CombinePropertiesFilesAction.java | 2 +- .../rename/RenamePropertyProcessor.java | 2 +- .../idea/svn/revert/CmdRevertClient.java | 2 +- .../idea/svn/upgrade/CmdUpgradeClient.java | 2 +- .../intellij/tasks/actions/GotoTaskAction.java | 2 +- .../intentions/PyQuotedStringIntention.java | 2 +- .../PyStringConcatenationToFormatIntention.java | 2 +- .../inspections/PyStringFormatInspection.java | 2 +- .../smartEnter/fixers/PyStringLiteralFixer.java | 12 ++++++------ .../debugger/array/AsyncArrayTableModel.java | 2 +- .../completion/XmlAttributeInsertHandler.java | 2 +- .../editorActions/XmlEqTypedHandler.java | 2 +- .../lang/html/HtmlQuotesFormatPreprocessor.java | 2 +- .../psi/impl/source/xml/XmlDoctypeImpl.java | 2 +- 63 files changed, 114 insertions(+), 107 deletions(-) diff --git a/java/debugger/impl/src/com/intellij/debugger/ui/tree/render/PrimitiveRenderer.java b/java/debugger/impl/src/com/intellij/debugger/ui/tree/render/PrimitiveRenderer.java index 32e27e48b8c5..13604b89abc0 100644 --- a/java/debugger/impl/src/com/intellij/debugger/ui/tree/render/PrimitiveRenderer.java +++ b/java/debugger/impl/src/com/intellij/debugger/ui/tree/render/PrimitiveRenderer.java @@ -85,7 +85,7 @@ public class PrimitiveRenderer extends NodeRendererImpl { static void appendCharValue(CharValue value, StringBuilder buf) { buf.append('\''); String s = value.toString(); - StringUtil.escapeStringCharacters(s.length(), s, "\'", buf); + StringUtil.escapeStringCharacters(s.length(), s, "'", buf); buf.append('\''); } diff --git a/java/idea-ui/src/com/intellij/ide/projectWizard/ModuleNameLocationComponent.java b/java/idea-ui/src/com/intellij/ide/projectWizard/ModuleNameLocationComponent.java index b3743f1c091f..ecfda21c2b7c 100644 --- a/java/idea-ui/src/com/intellij/ide/projectWizard/ModuleNameLocationComponent.java +++ b/java/idea-ui/src/com/intellij/ide/projectWizard/ModuleNameLocationComponent.java @@ -212,7 +212,7 @@ public class ModuleNameLocationComponent implements ModuleNameLocationSettings { module = ModuleManager.getInstance(project).findModuleByName(moduleName); } if (module != null) { - throw new ConfigurationException("Module \'" + moduleName + "\' already exist in project. Please, specify another name."); + throw new ConfigurationException("Module '" + moduleName + "' already exist in project. Please, specify another name."); } } diff --git a/java/idea-ui/src/com/intellij/ide/util/newProjectWizard/modes/CreateModuleFromSourcesMode.java b/java/idea-ui/src/com/intellij/ide/util/newProjectWizard/modes/CreateModuleFromSourcesMode.java index 13e7e780f35d..310d12780828 100644 --- a/java/idea-ui/src/com/intellij/ide/util/newProjectWizard/modes/CreateModuleFromSourcesMode.java +++ b/java/idea-ui/src/com/intellij/ide/util/newProjectWizard/modes/CreateModuleFromSourcesMode.java @@ -55,10 +55,10 @@ public class CreateModuleFromSourcesMode extends CreateFromSourcesMode { final String path = myPathPanel.getText().trim(); final File file = new File(path); if (!file.exists()) { - throw new ConfigurationException("File \'" + path + "\' doesn't exist"); + throw new ConfigurationException("File '" + path + "' doesn't exist"); } if (!file.isDirectory()) { - throw new ConfigurationException("\'" + path + "\' is not a directory"); + throw new ConfigurationException("'" + path + "' is not a directory"); } return super.validate(); } diff --git a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/QualifyThisOrSuperArgumentFix.java b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/QualifyThisOrSuperArgumentFix.java index 76722a86c378..0b650dbf7342 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/QualifyThisOrSuperArgumentFix.java +++ b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/QualifyThisOrSuperArgumentFix.java @@ -58,7 +58,7 @@ public abstract class QualifyThisOrSuperArgumentFix implements IntentionAction { public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) { if (!myExpression.isValid()) return false; if (!myPsiClass.isValid()) return false; - myText = "Qualify " + getQualifierText() + " expression with \'" + myPsiClass.getQualifiedName() + "\'"; + myText = "Qualify " + getQualifierText() + " expression with '" + myPsiClass.getQualifiedName() + "'"; return true; } diff --git a/java/java-impl/src/com/intellij/application/options/CodeStyleGenerationConfigurable.java b/java/java-impl/src/com/intellij/application/options/CodeStyleGenerationConfigurable.java index e2e165b712c3..6da91a0f4a63 100644 --- a/java/java-impl/src/com/intellij/application/options/CodeStyleGenerationConfigurable.java +++ b/java/java-impl/src/com/intellij/application/options/CodeStyleGenerationConfigurable.java @@ -191,7 +191,7 @@ public class CodeStyleGenerationConfigurable implements CodeStyleConfigurable { text = text.trim(); if (text.isEmpty()) return text; if (!StringUtil.isJavaIdentifier(text)) { - throw new ConfigurationException("Not a valid java identifier part in " + (prefix ? "prefix" : "suffix") + " \'" + text + "\'"); + throw new ConfigurationException("Not a valid java identifier part in " + (prefix ? "prefix" : "suffix") + " '" + text + "'"); } return text; } diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/PullAsAbstractUpFix.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/PullAsAbstractUpFix.java index ccdde96dc454..ebde5fddf86d 100644 --- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/PullAsAbstractUpFix.java +++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/PullAsAbstractUpFix.java @@ -143,25 +143,25 @@ public class PullAsAbstractUpFix extends LocalQuickFixAndIntentionActionOnPsiEle final PsiManager manager = containingClass.getManager(); boolean canBePulledUp = true; - String name = "Pull method \'" + methodWithOverrides.getName() + "\' up"; + String name = "Pull method '" + methodWithOverrides.getName() + "' up"; if (containingClass instanceof PsiAnonymousClass) { final PsiClassType baseClassType = ((PsiAnonymousClass)containingClass).getBaseClassType(); final PsiClass baseClass = baseClassType.resolve(); if (baseClass == null) return; if (!BaseIntentionAction.canModify(baseClass)) return; if (!baseClass.hasModifierProperty(PsiModifier.ABSTRACT)) { - name = "Pull method \'" + methodWithOverrides.getName() + "\' up and make it abstract"; + name = "Pull method '" + methodWithOverrides.getName() + "' up and make it abstract"; } } else { final LinkedHashSet classesToPullUp = new LinkedHashSet<>(); collectClassesToPullUp(manager, classesToPullUp, containingClass.getExtendsListTypes()); collectClassesToPullUp(manager, classesToPullUp, containingClass.getImplementsListTypes()); if (classesToPullUp.isEmpty()) { - name = "Extract method \'" + methodWithOverrides.getName() + "\' to new interface"; + name = "Extract method '" + methodWithOverrides.getName() + "' to new interface"; canBePulledUp = false; } else if (classesToPullUp.size() == 1) { final PsiClass baseClass = classesToPullUp.iterator().next(); - name = "Pull method \'" + methodWithOverrides.getName() + "\' to \'" + baseClass.getName() + "\'"; + name = "Pull method '" + methodWithOverrides.getName() + "' to '" + baseClass.getName() + "'"; if (!baseClass.hasModifierProperty(PsiModifier.ABSTRACT)) { name+= " and make it abstract"; } diff --git a/java/java-impl/src/com/intellij/codeInsight/editorActions/StringLiteralCopyPasteProcessor.java b/java/java-impl/src/com/intellij/codeInsight/editorActions/StringLiteralCopyPasteProcessor.java index 820e7e8dcc20..262d60c5a7af 100644 --- a/java/java-impl/src/com/intellij/codeInsight/editorActions/StringLiteralCopyPasteProcessor.java +++ b/java/java-impl/src/com/intellij/codeInsight/editorActions/StringLiteralCopyPasteProcessor.java @@ -250,7 +250,7 @@ public class StringLiteralCopyPasteProcessor implements CopyPastePreProcessor { @NotNull protected String escapeCharCharacters(@NotNull String s, @NotNull PsiElement token) { StringBuilder buffer = new StringBuilder(); - StringUtil.escapeStringCharacters(s.length(), s, isStringLiteral(token) ? "\"" : "\'", buffer); + StringUtil.escapeStringCharacters(s.length(), s, isStringLiteral(token) ? "\"" : "'", buffer); return buffer.toString(); } diff --git a/java/java-impl/src/com/intellij/codeInsight/editorActions/smartEnter/LiteralFixer.java b/java/java-impl/src/com/intellij/codeInsight/editorActions/smartEnter/LiteralFixer.java index 7070f30a1b4e..e6bee08d0509 100644 --- a/java/java-impl/src/com/intellij/codeInsight/editorActions/smartEnter/LiteralFixer.java +++ b/java/java-impl/src/com/intellij/codeInsight/editorActions/smartEnter/LiteralFixer.java @@ -32,7 +32,7 @@ public class LiteralFixer implements Fixer { editor.getDocument().insertString(psiElement.getTextRange().getEndOffset(), "\""); } else if (((PsiJavaToken) psiElement).getTokenType() == JavaTokenType.CHARACTER_LITERAL && !StringUtil.endsWithChar(psiElement.getText(), '\'')) { - editor.getDocument().insertString(psiElement.getTextRange().getEndOffset(), "\'"); + editor.getDocument().insertString(psiElement.getTextRange().getEndOffset(), "'"); } } } diff --git a/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassDialog.java b/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassDialog.java index 1e609f19d9de..96f0878313d7 100644 --- a/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassDialog.java @@ -159,7 +159,7 @@ class ExtractClassDialog extends RefactoringDialog implements MemberInfoChangeLi final String className = getClassName(); if (className.length() == 0 || !nameHelper.isIdentifier(className)) { - throw new ConfigurationException("\'" + className + "\' is invalid extracted class name"); + throw new ConfigurationException("'" + className + "' is invalid extracted class name"); } /*final String packageName = getPackageName(); @@ -169,7 +169,7 @@ class ExtractClassDialog extends RefactoringDialog implements MemberInfoChangeLi for (PsiClass innerClass : innerClasses) { if (className.equals(innerClass.getName())) { throw new ConfigurationException( - "Extracted class should have unique name. Name " + "\'" + className + "\' is already in use by one of the inner classes"); + "Extracted class should have unique name. Name " + "'" + className + "' is already in use by one of the inner classes"); } } } diff --git a/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassProcessor.java b/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassProcessor.java index 0035cfa6bd7c..b79cf84e97a3 100644 --- a/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassProcessor.java +++ b/java/java-impl/src/com/intellij/refactoring/extractclass/ExtractClassProcessor.java @@ -175,13 +175,13 @@ public class ExtractClassProcessor extends FixableUsagesRefactoringProcessor { fieldsNeedingGetter.addAll(visitor.getFieldsNeedingGetter()); fieldsNeedingGetter.addAll(srcVisitor.getFieldsNeedingGetter()); for (PsiField field : fieldsNeedingGetter) { - conflicts.putValue(field, "Field \'" + field.getName() + "\' needs getter"); + conflicts.putValue(field, "Field '" + field.getName() + "' needs getter"); } final Set fieldsNeedingSetter = new LinkedHashSet<>(); fieldsNeedingSetter.addAll(visitor.getFieldsNeedingSetter()); fieldsNeedingSetter.addAll(srcVisitor.getFieldsNeedingSetter()); for (PsiField field : fieldsNeedingSetter) { - conflicts.putValue(field, "Field \'" + field.getName() + "\' needs setter"); + conflicts.putValue(field, "Field '" + field.getName() + "' needs setter"); } } checkConflicts(refUsages, conflicts); diff --git a/java/java-impl/src/com/intellij/refactoring/inheritanceToDelegation/InheritanceToDelegationDialog.java b/java/java-impl/src/com/intellij/refactoring/inheritanceToDelegation/InheritanceToDelegationDialog.java index 284d1a75e9cc..589084471f4a 100644 --- a/java/java-impl/src/com/intellij/refactoring/inheritanceToDelegation/InheritanceToDelegationDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/inheritanceToDelegation/InheritanceToDelegationDialog.java @@ -98,12 +98,12 @@ public class InheritanceToDelegationDialog extends RefactoringDialog { final String fieldName = getFieldName(); final PsiNameHelper helper = PsiNameHelper.getInstance(myProject); if (!helper.isIdentifier(fieldName)){ - throw new ConfigurationException("\'" + fieldName + "\' is invalid field name for delegation"); + throw new ConfigurationException("'" + fieldName + "' is invalid field name for delegation"); } if (myInnerClassNameField != null) { final String className = myInnerClassNameField.getEnteredName(); if (!helper.isIdentifier(className)) { - throw new ConfigurationException("\'" + className + "\' is invalid inner class name"); + throw new ConfigurationException("'" + className + "' is invalid inner class name"); } } } diff --git a/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/InlineSuperClassRefactoringProcessor.java b/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/InlineSuperClassRefactoringProcessor.java index da89cc41326f..f292ca1990e7 100644 --- a/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/InlineSuperClassRefactoringProcessor.java +++ b/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/InlineSuperClassRefactoringProcessor.java @@ -238,7 +238,7 @@ public class InlineSuperClassRefactoringProcessor extends FixableUsagesRefactori conflicts.putValue(targetClass, "Cannot inline into anonymous class."); } else if (PsiTreeUtil.isAncestor(mySuperClass, targetClass, false)) { - conflicts.putValue(targetClass, "Cannot inline into the inner class. Move \'" + targetClass.getName() + "\' to upper level"); + conflicts.putValue(targetClass, "Cannot inline into the inner class. Move '" + targetClass.getName() + "' to upper level"); } else { for (MemberInfo info : myMemberInfos) { diff --git a/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/usageInfo/ReplaceWithSubtypeUsageInfo.java b/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/usageInfo/ReplaceWithSubtypeUsageInfo.java index 236fcf73ef0e..3ddbe1e375c1 100644 --- a/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/usageInfo/ReplaceWithSubtypeUsageInfo.java +++ b/java/java-impl/src/com/intellij/refactoring/inlineSuperClass/usageInfo/ReplaceWithSubtypeUsageInfo.java @@ -59,11 +59,11 @@ public class ReplaceWithSubtypeUsageInfo extends FixableUsageInfo { if (!TypeConversionUtil.isAssignable(myOriginalType, myTargetClassType)) { final String conflict = "No consistent substitution found for " + getElement().getText() + - ". Expected \'" + + ". Expected '" + myOriginalType.getPresentableText() + - "\' but found \'" + + "' but found '" + myTargetClassType.getPresentableText() + - "\'."; + "'."; if (myConflict == null) { myConflict = conflict; } else { diff --git a/java/java-impl/src/com/intellij/refactoring/introduceParameter/IntroduceParameterDialog.java b/java/java-impl/src/com/intellij/refactoring/introduceParameter/IntroduceParameterDialog.java index 9c2afd54d518..72454181c5d7 100644 --- a/java/java-impl/src/com/intellij/refactoring/introduceParameter/IntroduceParameterDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/introduceParameter/IntroduceParameterDialog.java @@ -290,7 +290,7 @@ public class IntroduceParameterDialog extends RefactoringDialog { protected void canRun() throws ConfigurationException { String name = getParameterName(); if (!PsiNameHelper.getInstance(myProject).isIdentifier(name)) { - throw new ConfigurationException("\'" + name + "\' is invalid parameter name"); + throw new ConfigurationException("'" + name + "' is invalid parameter name"); } } diff --git a/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/IntroduceParameterObjectDialog.java b/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/IntroduceParameterObjectDialog.java index 8ffa410007a4..84a2804bfcf7 100644 --- a/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/IntroduceParameterObjectDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/IntroduceParameterObjectDialog.java @@ -203,26 +203,28 @@ public class IntroduceParameterObjectDialog extends AbstractIntroduceParameterOb final PsiNameHelper nameHelper = PsiNameHelper.getInstance(project); if (myCreateInnerClassRadioButton.isSelected()) { final String innerClassName = getInnerClassName(); - if (!nameHelper.isIdentifier(innerClassName)) throw new ConfigurationException("\'" + innerClassName + "\' is invalid inner class name"); - if (mySourceMethod.getContainingClass().findInnerClassByName(innerClassName, false) != null) throw new ConfigurationException("Inner class with name \'" + innerClassName + "\' already exist"); + if (!nameHelper.isIdentifier(innerClassName)) throw new ConfigurationException("'" + innerClassName + "' is invalid inner class name"); + if (mySourceMethod.getContainingClass().findInnerClassByName(innerClassName, false) != null) throw new ConfigurationException( + "Inner class with name '" + innerClassName + + "' already exist"); } else if (!useExistingClass()) { final String className = getClassName(); if (className.length() == 0 || !nameHelper.isIdentifier(className)) { - throw new ConfigurationException("\'" + className + "\' is invalid parameter class name"); + throw new ConfigurationException("'" + className + "' is invalid parameter class name"); } final String packageName = getPackageName(); if (packageName.length() == 0 || !nameHelper.isQualifiedName(packageName)) { - throw new ConfigurationException("\'" + packageName + "\' is invalid parameter class package name"); + throw new ConfigurationException("'" + packageName + "' is invalid parameter class package name"); } } else { final String className = getExistingClassName(); if (className.length() == 0 || !nameHelper.isQualifiedName(className)) { - throw new ConfigurationException("\'" + className + "\' is invalid qualified parameter class name"); + throw new ConfigurationException("'" + className + "' is invalid qualified parameter class name"); } if (JavaPsiFacade.getInstance(getProject()).findClass(className, GlobalSearchScope.allScope(getProject())) == null) { - throw new ConfigurationException("\'" + className + "\' does not exist"); + throw new ConfigurationException("'" + className + "' does not exist"); } } } diff --git a/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/usageInfo/AppendAccessorsUsageInfo.java b/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/usageInfo/AppendAccessorsUsageInfo.java index e2e72c2b2a89..5bf1715ac294 100644 --- a/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/usageInfo/AppendAccessorsUsageInfo.java +++ b/java/java-impl/src/com/intellij/refactoring/introduceparameterobject/usageInfo/AppendAccessorsUsageInfo.java @@ -69,7 +69,7 @@ public class AppendAccessorsUsageInfo extends FixableUsageInfo{ if (myField != null) { fieldName = myField.getName(); } - return (myGetter ? "Getter" : "Setter") + " for field \'" + fieldName + "\' is required"; + return (myGetter ? "Getter" : "Setter") + " for field '" + fieldName + "' is required"; } return null; } diff --git a/java/java-impl/src/com/intellij/refactoring/move/moveClassesOrPackages/JavaMoveClassesOrPackagesHandler.java b/java/java-impl/src/com/intellij/refactoring/move/moveClassesOrPackages/JavaMoveClassesOrPackagesHandler.java index c3bf6f59bc99..014fe436a18a 100644 --- a/java/java-impl/src/com/intellij/refactoring/move/moveClassesOrPackages/JavaMoveClassesOrPackagesHandler.java +++ b/java/java-impl/src/com/intellij/refactoring/move/moveClassesOrPackages/JavaMoveClassesOrPackagesHandler.java @@ -332,9 +332,9 @@ public class JavaMoveClassesOrPackagesHandler extends MoveHandlerDelegate { inLib |= !fileIndex.isInContent(psiDirectory.getVirtualFile()); } - return inLib ? "Package \'" + + return inLib ? "Package '" + aPackage.getName() + - "\' contains directories in libraries which cannot be moved. Do you want to move current directory" : null; + "' contains directories in libraries which cannot be moved. Do you want to move current directory" : null; } private static boolean canMoveOrRearrangePackages(PsiElement[] elements) { diff --git a/java/java-impl/src/com/intellij/refactoring/rename/RenamePsiPackageProcessor.java b/java/java-impl/src/com/intellij/refactoring/rename/RenamePsiPackageProcessor.java index f918e691e2cd..510636e2b7b1 100644 --- a/java/java-impl/src/com/intellij/refactoring/rename/RenamePsiPackageProcessor.java +++ b/java/java-impl/src/com/intellij/refactoring/rename/RenamePsiPackageProcessor.java @@ -146,7 +146,7 @@ public class RenamePsiPackageProcessor extends RenamePsiElementProcessor { final String qualifiedNameAfterRename = getPackageQualifiedNameAfterRename(aPackage, newName, true); final PsiClass psiClass = JavaPsiFacade.getInstance(project).findClass(qualifiedNameAfterRename, GlobalSearchScope.allScope(project)); if (psiClass != null) { - conflicts.putValue(psiClass, "Class with qualified name \'" + qualifiedNameAfterRename + "\' already exist"); + conflicts.putValue(psiClass, "Class with qualified name '" + qualifiedNameAfterRename + "' already exist"); } } diff --git a/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java b/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java index aa6fd23c90db..8831e6381d0d 100644 --- a/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java @@ -198,17 +198,22 @@ public class ReplaceConstructorWithBuilderDialog extends RefactoringDialog { protected void canRun() throws ConfigurationException { final PsiNameHelper nameHelper = PsiNameHelper.getInstance(myProject); for (ParameterData parameterData : myParametersMap.values()) { - if (!nameHelper.isIdentifier(parameterData.getFieldName())) throw new ConfigurationException("\'" + parameterData.getFieldName() + "\' is not a valid field name"); - if (!nameHelper.isIdentifier(parameterData.getSetterName())) throw new ConfigurationException("\'" + parameterData.getSetterName() + "\' is not a valid setter name"); + if (!nameHelper.isIdentifier(parameterData.getFieldName())) throw new ConfigurationException("'" + parameterData.getFieldName() + + "' is not a valid field name"); + if (!nameHelper.isIdentifier(parameterData.getSetterName())) throw new ConfigurationException("'" + parameterData.getSetterName() + + "' is not a valid setter name"); } if (myCreateBuilderClassRadioButton.isSelected()) { final String className = myNewClassName.getText().trim(); - if (className.length() == 0 || !nameHelper.isQualifiedName(className)) throw new ConfigurationException("\'" + className + "\' is invalid builder class name"); + if (className.length() == 0 || !nameHelper.isQualifiedName(className)) throw new ConfigurationException("'" + className + + "' is invalid builder class name"); final String packageName = myPackageTextField.getText().trim(); - if (packageName.length() > 0 && !nameHelper.isQualifiedName(packageName)) throw new ConfigurationException("\'" + packageName + "\' is invalid builder package name"); + if (packageName.length() > 0 && !nameHelper.isQualifiedName(packageName)) throw new ConfigurationException("'" + packageName + + "' is invalid builder package name"); } else { final String qualifiedName = myExistentClassTF.getText().trim(); - if (qualifiedName.length() == 0 || !nameHelper.isQualifiedName(qualifiedName)) throw new ConfigurationException("\'" + qualifiedName + "\' is invalid builder qualified class name"); + if (qualifiedName.length() == 0 || !nameHelper.isQualifiedName(qualifiedName)) throw new ConfigurationException("'" + qualifiedName + + "' is invalid builder qualified class name"); } } @@ -397,7 +402,7 @@ public class ReplaceConstructorWithBuilderDialog extends RefactoringDialog { return null; } return !PsiNameHelper.getInstance(myProject).isIdentifier(inputString) - ? "Identifier \'" + inputString + "\' is invalid" : null; + ? "Identifier '" + inputString + "' is invalid" : null; } } } diff --git a/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithFactory/ReplaceConstructorWithFactoryDialog.java b/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithFactory/ReplaceConstructorWithFactoryDialog.java index 99dc3005a673..c8a29d7f275a 100644 --- a/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithFactory/ReplaceConstructorWithFactoryDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithFactory/ReplaceConstructorWithFactoryDialog.java @@ -191,7 +191,7 @@ public class ReplaceConstructorWithFactoryDialog extends RefactoringDialog { final String name = myNameField.getEnteredName(); final PsiNameHelper nameHelper = PsiNameHelper.getInstance(myContainingClass.getProject()); if (!nameHelper.isIdentifier(name)) { - throw new ConfigurationException("\'" + name + "\' is invalid factory method name"); + throw new ConfigurationException("'" + name + "' is invalid factory method name"); } } } \ No newline at end of file diff --git a/java/java-impl/src/com/intellij/refactoring/typeMigration/ui/TypeMigrationDialog.java b/java/java-impl/src/com/intellij/refactoring/typeMigration/ui/TypeMigrationDialog.java index abf5d4ba68f5..acd83d4cdb53 100644 --- a/java/java-impl/src/com/intellij/refactoring/typeMigration/ui/TypeMigrationDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/typeMigration/ui/TypeMigrationDialog.java @@ -181,8 +181,8 @@ public abstract class TypeMigrationDialog extends RefactoringDialog { protected void canRun() throws ConfigurationException { super.canRun(); if (!checkType(getMigrationType())) - throw new ConfigurationException("\'" + StringUtil.escapeXmlEntities(myTypeCodeFragment.getText()) + "\' is an invalid type"); - if (isVoidVariableMigration()) throw new ConfigurationException("\'void\' is not applicable"); + throw new ConfigurationException("'" + StringUtil.escapeXmlEntities(myTypeCodeFragment.getText()) + "' is an invalid type"); + if (isVoidVariableMigration()) throw new ConfigurationException("'void' is not applicable"); } @Override diff --git a/java/java-impl/src/com/intellij/refactoring/wrapreturnvalue/WrapReturnValueDialog.java b/java/java-impl/src/com/intellij/refactoring/wrapreturnvalue/WrapReturnValueDialog.java index e89b5faf0fef..fd66f9c276ed 100644 --- a/java/java-impl/src/com/intellij/refactoring/wrapreturnvalue/WrapReturnValueDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/wrapreturnvalue/WrapReturnValueDialog.java @@ -96,15 +96,15 @@ class WrapReturnValueDialog extends RefactoringDialog { final PsiNameHelper nameHelper = PsiNameHelper.getInstance(project); if (myCreateInnerClassButton.isSelected()) { final String innerClassName = getInnerClassName().trim(); - if (!nameHelper.isIdentifier(innerClassName)) throw new ConfigurationException("\'" + innerClassName + "\' is invalid inner class name"); + if (!nameHelper.isIdentifier(innerClassName)) throw new ConfigurationException("'" + innerClassName + "' is invalid inner class name"); final PsiClass containingClass = sourceMethod.getContainingClass(); if (containingClass != null && containingClass.findInnerClassByName(innerClassName, false) != null) { - throw new ConfigurationException("Inner class with name \'" + innerClassName + "\' already exist"); + throw new ConfigurationException("Inner class with name '" + innerClassName + "' already exist"); } } else if (useExistingClassButton.isSelected()) { final String className = existingClassField.getText().trim(); if (className.length() == 0 || !nameHelper.isQualifiedName(className)) { - throw new ConfigurationException("\'" + className + "\' is invalid qualified wrapper class name"); + throw new ConfigurationException("'" + className + "' is invalid qualified wrapper class name"); } final Object item = myFieldsCombo.getSelectedItem(); if (item == null) { @@ -113,12 +113,12 @@ class WrapReturnValueDialog extends RefactoringDialog { } else { final String className = getClassName(); if (className.length() == 0 || !nameHelper.isIdentifier(className)) { - throw new ConfigurationException("\'" + className + "\' is invalid wrapper class name"); + throw new ConfigurationException("'" + className + "' is invalid wrapper class name"); } final String packageName = getPackageName(); if (packageName.length() == 0 || !nameHelper.isQualifiedName(packageName)) { - throw new ConfigurationException("\'" + packageName + "\' is invalid wrapper class package name"); + throw new ConfigurationException("'" + packageName + "' is invalid wrapper class package name"); } } } diff --git a/platform/core-impl/src/com/intellij/ide/highlighter/custom/CustomFileTypeLexer.java b/platform/core-impl/src/com/intellij/ide/highlighter/custom/CustomFileTypeLexer.java index 9cc15eb5d470..096a263fc35a 100644 --- a/platform/core-impl/src/com/intellij/ide/highlighter/custom/CustomFileTypeLexer.java +++ b/platform/core-impl/src/com/intellij/ide/highlighter/custom/CustomFileTypeLexer.java @@ -52,7 +52,7 @@ public final class CustomFileTypeLexer extends AbstractCustomLexer { final QuotedStringParser quotedStringParser = new QuotedStringParser("\"", CustomHighlighterTokenType.STRING, table.isHasStringEscapes()); final QuotedStringParser quotedStringParser2 = new QuotedStringParser( - "\'", + "'", forHighlighting ? CustomHighlighterTokenType.SINGLE_QUOTED_STRING:CustomHighlighterTokenType.STRING, table.isHasStringEscapes() ); diff --git a/platform/core-impl/src/com/intellij/psi/impl/source/CharTableImpl.java b/platform/core-impl/src/com/intellij/psi/impl/source/CharTableImpl.java index 4f6c0ec679f1..71e0ef1d7d2a 100644 --- a/platform/core-impl/src/com/intellij/psi/impl/source/CharTableImpl.java +++ b/platform/core-impl/src/com/intellij/psi/impl/source/CharTableImpl.java @@ -165,7 +165,7 @@ public class CharTableImpl implements CharTable { r.add(""); r.add("\""); - r.add("\'"); + r.add("'"); r.add(""); r.add("