diff --git a/platform/util/src/com/intellij/util/containers/JBIterator.java b/platform/util/src/com/intellij/util/containers/JBIterator.java index c74dd2e9749e..6e2ed271c93a 100644 --- a/platform/util/src/com/intellij/util/containers/JBIterator.java +++ b/platform/util/src/com/intellij/util/containers/JBIterator.java @@ -370,7 +370,8 @@ public abstract class JBIterator implements Iterator { @Override Object apply(Object o) { JBIterator it = (JBIterator)o; - return ((advanced = nextOp != null) ? it.advance() : it.hasNext()) ? it : stop(); + advanced = nextOp != null; + return (advanced ? it.advance() : it.hasNext()) ? it : stop(); } void advance(Object o) { diff --git a/plugins/java-decompiler/engine/src/org/jetbrains/java/decompiler/modules/decompiler/IfHelper.java b/plugins/java-decompiler/engine/src/org/jetbrains/java/decompiler/modules/decompiler/IfHelper.java index afcf55e1429a..66e857c7ca3f 100644 --- a/plugins/java-decompiler/engine/src/org/jetbrains/java/decompiler/modules/decompiler/IfHelper.java +++ b/plugins/java-decompiler/engine/src/org/jetbrains/java/decompiler/modules/decompiler/IfHelper.java @@ -31,7 +31,8 @@ public final class IfHelper { res |= mergeAllIfsRec(st, setReorderedIfs); // collapse composed if's - if (changed = mergeIfs(st, setReorderedIfs)) { + if (mergeIfs(st, setReorderedIfs)) { + changed = true; break; } } @@ -75,21 +76,25 @@ public final class IfHelper { continue; } - if (updated = collapseIfIf(rtnode)) { + if (collapseIfIf(rtnode)) { + updated = true; break; } if (!setReorderedIfs.contains(stat.id)) { - if (updated = collapseIfElse(rtnode)) { + if (collapseIfElse(rtnode)) { + updated = true; break; } - if (updated = collapseElse(rtnode)) { + if (collapseElse(rtnode)) { + updated = true; break; } } - if (updated = reorderIf((IfStatement)stat)) { + if (reorderIf((IfStatement)stat)) { + updated = true; setReorderedIfs.add(stat.id); break; } @@ -440,10 +445,9 @@ public final class IfHelper { if (sttemp == ifstat) { break; } - else { - if (elsedirectpath = existsPath(sttemp, next)) { - break; - } + else if (existsPath(sttemp, next)) { + elsedirectpath = true; + break; } } }