From 798178da08e831fc5f4943d0f63d75fcc21f5159 Mon Sep 17 00:00:00 2001 From: Andrey Lisin Date: Fri, 9 Feb 2024 12:22:02 +0100 Subject: [PATCH] Cleanup: better naming and API logic GitOrigin-RevId: e543a3a06c7817508b164acdf3df2c79b7841c31 --- python/testSrc/com/jetbrains/env/PyEnvTaskRunner.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/python/testSrc/com/jetbrains/env/PyEnvTaskRunner.java b/python/testSrc/com/jetbrains/env/PyEnvTaskRunner.java index 9d7c107a65f6..aac296309d64 100644 --- a/python/testSrc/com/jetbrains/env/PyEnvTaskRunner.java +++ b/python/testSrc/com/jetbrains/env/PyEnvTaskRunner.java @@ -111,7 +111,7 @@ public class PyEnvTaskRunner { } catch (final RuntimeException | Error ex) { // Runtime and error are logged including environment info - LOG.warn(joinStrings(passedRoots, "Tests passed environments: ") + + LOG.warn(formatCollectionToString(passedRoots, "Tests passed environments") + "Test failed on " + getEnvType() + " environment " + @@ -137,9 +137,9 @@ public class PyEnvTaskRunner { throw new RuntimeException("test " + testName + " was not executed.\n" + - joinStrings(myRoots, "All roots: ") + + formatCollectionToString(myRoots, "All roots") + "\n" + - joinStrings(requiredTags, "Required tags in tags.txt in root: ")); + formatCollectionToString(requiredTags, "Required tags in tags.txt in root")); } } @@ -236,7 +236,7 @@ public class PyEnvTaskRunner { } @NotNull - private static String joinStrings(final Collection roots, final String rootsName) { - return !roots.isEmpty() ? rootsName + StringUtil.join(roots, ", ") + "\n" : ""; + private static String formatCollectionToString(Collection coll, String collName) { + return !coll.isEmpty() ? collName + ": " + StringUtil.join(coll, ", ") + "\n" : ""; } }