From 75bbe05d18cf446ffde1f13329d7a2fe8b36b9e1 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Wed, 6 Jul 2016 13:01:21 +0200 Subject: [PATCH] IG: warn on covariant equals() in interface but not implementations --- .../src/com/siyeh/ig/bugs/CovariantEqualsInspection.java | 2 +- .../com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java index 9310fee55930..5e89b0b9c519 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java @@ -68,7 +68,7 @@ public class CovariantEqualsInspection extends BaseInspection { return; } final PsiClass aClass = method.getContainingClass(); - if (aClass == null || aClass.isInterface()) { + if (aClass == null) { return; } final PsiMethod[] methods = aClass.getMethods(); diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java index 53d950c98cbd..e34f07954ea3 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java @@ -1,5 +1,5 @@ interface I { - boolean equals(I i); + boolean equals(I i); } class A {