From 730ee8aed4f2702d058a1ab2521793b8a91c3de4 Mon Sep 17 00:00:00 2001
From: Vladimir Krivosheev <vladimir.krivosheev@jetbrains.com>
Date: Tue, 18 Jun 2013 17:36:57 +0200
Subject: [PATCH] =?UTF-8?q?OpenFileInBrowserAction=20=E2=80=94=20disable?=
 =?UTF-8?q?=20in=20case=20of=20LightVirtualFile?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../ide/browsers/OpenFileInBrowserAction.java | 86 +++++++++++--------
 1 file changed, 49 insertions(+), 37 deletions(-)

diff --git a/xml/impl/src/com/intellij/ide/browsers/OpenFileInBrowserAction.java b/xml/impl/src/com/intellij/ide/browsers/OpenFileInBrowserAction.java
index 130fd1fc17f9..969e7f8b3793 100644
--- a/xml/impl/src/com/intellij/ide/browsers/OpenFileInBrowserAction.java
+++ b/xml/impl/src/com/intellij/ide/browsers/OpenFileInBrowserAction.java
@@ -25,6 +25,7 @@ import com.intellij.openapi.project.DumbAwareAction;
 import com.intellij.openapi.ui.Messages;
 import com.intellij.openapi.util.Pair;
 import com.intellij.psi.PsiFile;
+import com.intellij.testFramework.LightVirtualFile;
 import com.intellij.xml.XmlBundle;
 import com.intellij.xml.util.HtmlUtil;
 
@@ -39,48 +40,59 @@ public class OpenFileInBrowserAction extends DumbAwareAction {
     final PsiFile file = LangDataKeys.PSI_FILE.getData(dataContext);
     final Presentation presentation = e.getPresentation();
 
-    if (file != null && file.getVirtualFile() != null) {
-      presentation.setVisible(true);
+    if (file == null || file.getVirtualFile() == null) {
+      presentation.setVisible(false);
+      presentation.setEnabled(false);
+      return;
+    }
 
-      Pair<WebBrowserUrlProvider, Url> browserUrlProvider = WebBrowserServiceImpl.getProvider(file);
-      final boolean isHtmlFile = HtmlUtil.isHtmlFile(file);
-      presentation.setEnabled(browserUrlProvider != null || isHtmlFile);
-
-      String text = getTemplatePresentation().getText();
-      String description = getTemplatePresentation().getDescription();
-
-      if (browserUrlProvider != null) {
-        final String customText = browserUrlProvider.first.getOpenInBrowserActionText(file);
-        if (customText != null) {
-          text = customText;
-        }
-        final String customDescription = browserUrlProvider.first.getOpenInBrowserActionDescription(file);
-        if (customDescription != null) {
-          description = customDescription;
-        }
-        if (isHtmlFile) {
-          description += " (hold Shift to open URL of local file)";
-        }
+    Pair<WebBrowserUrlProvider, Url> browserUrlProvider = WebBrowserServiceImpl.getProvider(file);
+    final boolean isHtmlFile = HtmlUtil.isHtmlFile(file);
+    if (browserUrlProvider == null) {
+      if (file.getVirtualFile() instanceof LightVirtualFile) {
+        presentation.setVisible(false);
+        presentation.setEnabled(false);
+        return;
       }
-
-      presentation.setText(text);
-      presentation.setDescription(description);
-
-      GeneralSettings settings = GeneralSettings.getInstance();
-      if (!settings.isUseDefaultBrowser()) {
-        BrowsersConfiguration.BrowserFamily family = BrowsersConfiguration.getInstance().findFamilyByPath(settings.getBrowserPath());
-        if (family != null) {
-          presentation.setIcon(family.getIcon());
-        }
-      }
-
-      if (ActionPlaces.isPopupPlace(e.getPlace())) {
-        presentation.setVisible(presentation.isEnabled());
+      else {
+        presentation.setEnabled(isHtmlFile);
       }
     }
     else {
-      presentation.setVisible(false);
-      presentation.setEnabled(false);
+      presentation.setEnabled(true);
+    }
+    presentation.setVisible(true);
+
+    String text = getTemplatePresentation().getText();
+    String description = getTemplatePresentation().getDescription();
+
+    if (browserUrlProvider != null) {
+      final String customText = browserUrlProvider.first.getOpenInBrowserActionText(file);
+      if (customText != null) {
+        text = customText;
+      }
+      final String customDescription = browserUrlProvider.first.getOpenInBrowserActionDescription(file);
+      if (customDescription != null) {
+        description = customDescription;
+      }
+      if (isHtmlFile) {
+        description += " (hold Shift to open URL of local file)";
+      }
+    }
+
+    presentation.setText(text);
+    presentation.setDescription(description);
+
+    GeneralSettings settings = GeneralSettings.getInstance();
+    if (!settings.isUseDefaultBrowser()) {
+      BrowsersConfiguration.BrowserFamily family = BrowsersConfiguration.getInstance().findFamilyByPath(settings.getBrowserPath());
+      if (family != null) {
+        presentation.setIcon(family.getIcon());
+      }
+    }
+
+    if (ActionPlaces.isPopupPlace(e.getPlace())) {
+      presentation.setVisible(presentation.isEnabled());
     }
   }