From 70aabe483045abf65943b86bdd5342c8f2d72162 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Tue, 27 Aug 2024 15:57:39 +0200 Subject: [PATCH] [java-inspections] AbstractClassNeverImplemented: improve description; reorder check for efficiency GitOrigin-RevId: 4a7508def1712070c231ddc3ce6fd804bbc05784 --- .../inheritance/AbstractClassNeverImplementedInspection.java | 4 ++-- .../inspectionDescriptions/AbstractClassNeverImplemented.html | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/java/java-analysis-impl/src/com/siyeh/ig/inheritance/AbstractClassNeverImplementedInspection.java b/java/java-analysis-impl/src/com/siyeh/ig/inheritance/AbstractClassNeverImplementedInspection.java index 9171d290479c..1203587777a6 100644 --- a/java/java-analysis-impl/src/com/siyeh/ig/inheritance/AbstractClassNeverImplementedInspection.java +++ b/java/java-analysis-impl/src/com/siyeh/ig/inheritance/AbstractClassNeverImplementedInspection.java @@ -48,10 +48,10 @@ public final class AbstractClassNeverImplementedInspection extends BaseInspectio if (!aClass.hasModifierProperty(PsiModifier.ABSTRACT)) { return; } - if (InheritanceUtil.hasImplementation(aClass)) { + if (aClass.isDeprecated()) { return; } - if (aClass.isDeprecated()) { + if (InheritanceUtil.hasImplementation(aClass)) { return; } registerClassError(aClass); diff --git a/java/java-impl/src/inspectionDescriptions/AbstractClassNeverImplemented.html b/java/java-impl/src/inspectionDescriptions/AbstractClassNeverImplemented.html index 20df3e0cac35..7c21b36cdf57 100644 --- a/java/java-impl/src/inspectionDescriptions/AbstractClassNeverImplemented.html +++ b/java/java-impl/src/inspectionDescriptions/AbstractClassNeverImplemented.html @@ -1,6 +1,6 @@ -Reports abstract classes that have no concrete subclasses. +Reports abstract classes that have no concrete subclasses. Deprecated abstract classes are not reported.