From 6f74d50f2fc2bbcfba37649643c5ddbe6665762a Mon Sep 17 00:00:00 2001 From: Mikhail Golubev Date: Tue, 4 Jul 2017 17:39:45 +0300 Subject: [PATCH] Explicitly dispose instance of PyChangeSignatureDialog in tests Since it's not actually shown in this case, its automatic disposal on close doesn't get invoked. --- .../inspections/quickfix/PyChangeSignatureQuickFix.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/python/src/com/jetbrains/python/inspections/quickfix/PyChangeSignatureQuickFix.java b/python/src/com/jetbrains/python/inspections/quickfix/PyChangeSignatureQuickFix.java index cc70c1ca71bf..5262abf1b2ca 100644 --- a/python/src/com/jetbrains/python/inspections/quickfix/PyChangeSignatureQuickFix.java +++ b/python/src/com/jetbrains/python/inspections/quickfix/PyChangeSignatureQuickFix.java @@ -21,6 +21,7 @@ import com.intellij.codeInspection.LocalQuickFixOnPsiElement; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.project.Project; import com.intellij.openapi.util.Conditions; +import com.intellij.openapi.util.Disposer; import com.intellij.openapi.util.Key; import com.intellij.openapi.util.Pair; import com.intellij.openapi.util.text.StringUtil; @@ -169,7 +170,12 @@ public class PyChangeSignatureQuickFix extends LocalQuickFixOnPsiElement { originalCallSite.putUserData(CHANGE_SIGNATURE_ORIGINAL_CALL, true); } if (ApplicationManager.getApplication().isUnitTestMode()) { - dialog.createRefactoringProcessor().run(); + try { + dialog.createRefactoringProcessor().run(); + } + finally { + Disposer.dispose(dialog.getDisposable()); + } } else { dialog.show();