From 6f03286536a2baaec9e0eaf63a6b1c218136c53d Mon Sep 17 00:00:00 2001 From: Kirill Likhodedov Date: Tue, 1 Sep 2015 12:12:00 +0300 Subject: [PATCH] [git] don't rely on the error output to identify if Git command failed. Check only the exit code. --- plugins/git4idea/src/git4idea/commands/GitImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/git4idea/src/git4idea/commands/GitImpl.java b/plugins/git4idea/src/git4idea/commands/GitImpl.java index 7e631a1cf147..a72e44215b0e 100644 --- a/plugins/git4idea/src/git4idea/commands/GitImpl.java +++ b/plugins/git4idea/src/git4idea/commands/GitImpl.java @@ -625,7 +625,7 @@ public class GitImpl implements Git { handler.runInCurrentThread(null); authFailed = handler.hasHttpAuthFailed(); - success = !startFailed.get() && errorOutput.isEmpty() && (handler.isIgnoredErrorCode(exitCode.get()) || exitCode.get() == 0); + success = !startFailed.get() && (handler.isIgnoredErrorCode(exitCode.get()) || exitCode.get() == 0); } while (authFailed && authAttempt++ < 2); return new GitCommandResult(success, exitCode.get(), errorOutput, output, null);