From 6dcbe2edbe9d1c8b6b7f3b0effff30bcc7021803 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Fri, 9 Sep 2016 12:31:15 +0200 Subject: [PATCH] IDEA-160837 ('... can be replaced with {@code ...}' inspection quick fix should convert angle brackets) --- .../ig/javadoc/HtmlTagCanBeJavadocTagInspection.java | 3 ++- .../javadoc/html_tag_can_be_javadoc_tag/Lt.after.java | 9 +++++++++ .../igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.java | 9 +++++++++ .../ig/fixes/javadoc/HtmlTagCanBeJavadocTagFixTest.java | 1 + 4 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.after.java create mode 100644 plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.java diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/javadoc/HtmlTagCanBeJavadocTagInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/javadoc/HtmlTagCanBeJavadocTagInspection.java index cf19d3368522..079d0a96b2d6 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/javadoc/HtmlTagCanBeJavadocTagInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/javadoc/HtmlTagCanBeJavadocTagInspection.java @@ -117,7 +117,8 @@ public class HtmlTagCanBeJavadocTagInspection extends BaseInspection { if (out.length() == "{@code".length() && endOffset - startOffset > 0 && !Character.isWhitespace(text.charAt(startOffset))) { out.append(' '); } - out.append(text, startOffset, endOffset); + final String s = text.substring(startOffset, endOffset); + out.append(StringUtil.unescapeXml(s)); } } diff --git a/plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.after.java b/plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.after.java new file mode 100644 index 000000000000..68bf50b5fd91 --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.after.java @@ -0,0 +1,9 @@ +/** + * < + * {@code 2 < 3} + * > + */ +class Lt { + + +} \ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.java b/plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.java new file mode 100644 index 000000000000..d229879fa863 --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igfixes/javadoc/html_tag_can_be_javadoc_tag/Lt.java @@ -0,0 +1,9 @@ +/** + * < + * 2 < 3 + * > + */ +class Lt { + + +} \ No newline at end of file diff --git a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/javadoc/HtmlTagCanBeJavadocTagFixTest.java b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/javadoc/HtmlTagCanBeJavadocTagFixTest.java index 710fe7864b66..a6676027f4ec 100644 --- a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/javadoc/HtmlTagCanBeJavadocTagFixTest.java +++ b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/javadoc/HtmlTagCanBeJavadocTagFixTest.java @@ -18,4 +18,5 @@ public class HtmlTagCanBeJavadocTagFixTest extends IGQuickFixesTestCase { public void testBraces2() { doTest(); } public void testSecond() { doTest(); } public void testMultiline() { doTest(); } + public void testLt() { doTest(); } } \ No newline at end of file