From 6c53cea21dfad5701e45251f8adebf7204677232 Mon Sep 17 00:00:00 2001 From: Dmitrii Gridin Date: Mon, 14 Jul 2025 15:53:22 +0200 Subject: [PATCH] [core] StubTreeBuilder#getStubBuilderType: optimize negative path There is no need to call `shouldBuildStubFor` if we have no intent to build a stub GitOrigin-RevId: 279cbbabe27fb290103e6daa2db7893388a9ae8d --- .../src/com/intellij/psi/stubs/StubTreeBuilder.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform/core-impl/src/com/intellij/psi/stubs/StubTreeBuilder.java b/platform/core-impl/src/com/intellij/psi/stubs/StubTreeBuilder.java index 588e35fd46ca..6319623b1a46 100644 --- a/platform/core-impl/src/com/intellij/psi/stubs/StubTreeBuilder.java +++ b/platform/core-impl/src/com/intellij/psi/stubs/StubTreeBuilder.java @@ -71,8 +71,10 @@ public final class StubTreeBuilder { if (stubDescriptor == null) return null; VirtualFile vFile = file.getFile(); - boolean shouldBuildStubFor = stubDescriptor.getStubDefinition().shouldBuildStubFor(vFile); - if (toBuild && !shouldBuildStubFor) return null; + if (toBuild) { + boolean shouldBuildStubFor = stubDescriptor.getStubDefinition().shouldBuildStubFor(vFile); + if (!shouldBuildStubFor) return null; + } PushedFilePropertiesRetriever pushedFilePropertiesRetriever = PushedFilePropertiesRetriever.getInstance(); @NotNull List properties = pushedFilePropertiesRetriever != null