From 6a3b36b5a4f769b146518d7d39f9bbbbdaf7d807 Mon Sep 17 00:00:00 2001 From: Yuriy Artamonov Date: Mon, 22 Dec 2025 12:04:31 +0100 Subject: [PATCH] [platform] IJPL-224518 Cleanup private modifier usages with extensions/services in intellij.devkit.* GitOrigin-RevId: 60ba9178c04c6b288b7cd405d393f6bedc1fca4f --- .../devkit-core/src/actions/NewRemoteDevModuleAction.kt | 2 +- .../src/contentReport/ContentReportGeneratedSourcesFilter.kt | 2 +- .../IntelliJSdkExternalAnnotationsUpdateStartupActivity.kt | 2 +- .../src/showcase/ComposeShowcaseAction.kt | 2 +- .../devkit/debugger/settings/DevKitDebuggerConfigurable.kt | 5 +++-- .../idea/devkit/debugger/settings/DisableIDEStateAction.kt | 2 +- .../src/org/jetbrains/idea/devkit/debugger/stepping.kt | 2 +- .../org/jetbrains/idea/devkit/stacktrace/FreezeDescriptor.kt | 2 +- 8 files changed, 10 insertions(+), 9 deletions(-) diff --git a/plugins/devkit/devkit-core/src/actions/NewRemoteDevModuleAction.kt b/plugins/devkit/devkit-core/src/actions/NewRemoteDevModuleAction.kt index 3aaff36a4d9f..5aa6149cfc5a 100644 --- a/plugins/devkit/devkit-core/src/actions/NewRemoteDevModuleAction.kt +++ b/plugins/devkit/devkit-core/src/actions/NewRemoteDevModuleAction.kt @@ -45,7 +45,7 @@ import javax.swing.JComponent private val LOG = fileLogger() -private class NewRemoteDevModuleAction : DumbAwareAction() { +internal class NewRemoteDevModuleAction : DumbAwareAction() { override fun getActionUpdateThread(): ActionUpdateThread { return ActionUpdateThread.BGT diff --git a/plugins/devkit/devkit-core/src/contentReport/ContentReportGeneratedSourcesFilter.kt b/plugins/devkit/devkit-core/src/contentReport/ContentReportGeneratedSourcesFilter.kt index 8c4a3230445e..9cd5389d6f1a 100644 --- a/plugins/devkit/devkit-core/src/contentReport/ContentReportGeneratedSourcesFilter.kt +++ b/plugins/devkit/devkit-core/src/contentReport/ContentReportGeneratedSourcesFilter.kt @@ -8,7 +8,7 @@ import com.intellij.openapi.roots.GeneratedSourceFilterNotification import com.intellij.openapi.roots.GeneratedSourcesFilter import com.intellij.openapi.vfs.VirtualFile -private class ContentReportGeneratedSourcesFilter : GeneratedSourcesFilter() { +internal class ContentReportGeneratedSourcesFilter : GeneratedSourcesFilter() { override fun isGeneratedSource(file: VirtualFile, project: Project): Boolean { return IntelliJProjectUtil.isIntelliJPlatformProject(project) && file.name == "plugin-content.yaml" } diff --git a/plugins/devkit/devkit-core/src/inspections/missingApi/update/IntelliJSdkExternalAnnotationsUpdateStartupActivity.kt b/plugins/devkit/devkit-core/src/inspections/missingApi/update/IntelliJSdkExternalAnnotationsUpdateStartupActivity.kt index 386366e1b9a5..0115bf5fdb8c 100644 --- a/plugins/devkit/devkit-core/src/inspections/missingApi/update/IntelliJSdkExternalAnnotationsUpdateStartupActivity.kt +++ b/plugins/devkit/devkit-core/src/inspections/missingApi/update/IntelliJSdkExternalAnnotationsUpdateStartupActivity.kt @@ -17,7 +17,7 @@ import org.jetbrains.idea.devkit.projectRoots.IdeaJdk /** * Startup activity that updates external annotations of IDEA JDKs configured in the project. */ -private class IntelliJSdkExternalAnnotationsUpdateStartupActivity : ProjectActivity { +internal class IntelliJSdkExternalAnnotationsUpdateStartupActivity : ProjectActivity { init { val application = ApplicationManager.getApplication() if (application.isUnitTestMode) { diff --git a/plugins/devkit/intellij.devkit.compose/src/showcase/ComposeShowcaseAction.kt b/plugins/devkit/intellij.devkit.compose/src/showcase/ComposeShowcaseAction.kt index 79ae4d5324bc..a92106ffecf8 100644 --- a/plugins/devkit/intellij.devkit.compose/src/showcase/ComposeShowcaseAction.kt +++ b/plugins/devkit/intellij.devkit.compose/src/showcase/ComposeShowcaseAction.kt @@ -19,7 +19,7 @@ private fun createComposeShowcaseComponent(): JComponent { } } -private class ComposeShowcaseAction : DumbAwareAction() { +internal class ComposeShowcaseAction : DumbAwareAction() { override fun getActionUpdateThread(): ActionUpdateThread = ActionUpdateThread.BGT override fun update(e: AnActionEvent) { diff --git a/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DevKitDebuggerConfigurable.kt b/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DevKitDebuggerConfigurable.kt index ef9d5359a446..aa7065a51e7b 100644 --- a/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DevKitDebuggerConfigurable.kt +++ b/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DevKitDebuggerConfigurable.kt @@ -2,14 +2,15 @@ package org.jetbrains.idea.devkit.debugger.settings import com.intellij.openapi.options.BoundSearchableConfigurable +import com.intellij.openapi.options.Configurable import com.intellij.openapi.options.ConfigurableProvider import com.intellij.openapi.ui.DialogPanel import com.intellij.ui.dsl.builder.bindSelected import com.intellij.ui.dsl.builder.panel import org.jetbrains.idea.devkit.debugger.DevKitDebuggerBundle -private class DevKitDebuggerConfigurableProvider : ConfigurableProvider() { - override fun createConfigurable() = DevKitDebuggerConfigurable() +internal class DevKitDebuggerConfigurableProvider : ConfigurableProvider() { + override fun createConfigurable(): Configurable = DevKitDebuggerConfigurable() } private class DevKitDebuggerConfigurable : BoundSearchableConfigurable(DevKitDebuggerBundle.message("configurable.name.ide.debugger"), "", "devkit.debugger") { diff --git a/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DisableIDEStateAction.kt b/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DisableIDEStateAction.kt index 07f5204ddfb0..80343a6fd2d0 100644 --- a/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DisableIDEStateAction.kt +++ b/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/settings/DisableIDEStateAction.kt @@ -9,7 +9,7 @@ import com.intellij.xdebugger.impl.ui.tree.XDebuggerTree import com.intellij.xdebugger.impl.ui.tree.nodes.XValueNodeImpl import org.jetbrains.idea.devkit.debugger.DevKitDebuggerBundle -private class DisableIDEStateAction : AnAction() { +internal class DisableIDEStateAction : AnAction() { override fun getActionUpdateThread() = ActionUpdateThread.EDT override fun update(e: AnActionEvent) { if (!DevKitDebuggerSettings.getInstance().showIdeState) { diff --git a/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/stepping.kt b/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/stepping.kt index 223b4b1302bf..9bbec3975e81 100644 --- a/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/stepping.kt +++ b/plugins/devkit/intellij.devkit.debugger/src/org/jetbrains/idea/devkit/debugger/stepping.kt @@ -40,7 +40,7 @@ private object PauseListener : DebuggerManagerListener { fun getSessionData(session: DebuggerSession): SessionThreadsData? = sessions[session] } -private class ResumeListener : SteppingListener { +internal class ResumeListener : SteppingListener { override fun beforeResume(suspendContext: SuspendContextImpl) { val sessionData = PauseListener.getSessionData(suspendContext.debugProcess.session) ?: return sessionData.resetNonCancellableSection(suspendContext) diff --git a/plugins/devkit/intellij.devkit.stacktrace/src/org/jetbrains/idea/devkit/stacktrace/FreezeDescriptor.kt b/plugins/devkit/intellij.devkit.stacktrace/src/org/jetbrains/idea/devkit/stacktrace/FreezeDescriptor.kt index 625e5cc3fef4..f537ff624366 100644 --- a/plugins/devkit/intellij.devkit.stacktrace/src/org/jetbrains/idea/devkit/stacktrace/FreezeDescriptor.kt +++ b/plugins/devkit/intellij.devkit.stacktrace/src/org/jetbrains/idea/devkit/stacktrace/FreezeDescriptor.kt @@ -24,7 +24,7 @@ internal suspend fun getFreezeRunDescriptor(text: String, project: Project): Run } } -private class FreezeTabContentProvider : StacktraceTabContentProvider { +internal class FreezeTabContentProvider : StacktraceTabContentProvider { override suspend fun createRunTabDescriptor(project: Project, text: String): RunContentDescriptor? { return getFreezeRunDescriptor(text, project) }