diff --git a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.form b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.form deleted file mode 100644 index 6991fd73ff6c..000000000000 --- a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.form +++ /dev/null @@ -1,34 +0,0 @@ - -
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
diff --git a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.java b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.java index f55955929d21..3bf96c287c7f 100644 --- a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.java +++ b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactErrorPanel.java @@ -18,16 +18,18 @@ package com.intellij.openapi.roots.ui.configuration.artifacts; import com.intellij.icons.AllIcons; import com.intellij.ide.IdeBundle; import com.intellij.openapi.roots.ui.configuration.projectRoot.daemon.ConfigurationErrorQuickFix; +import com.intellij.openapi.roots.ui.configuration.projectRoot.daemon.ProjectStructureProblemType; import com.intellij.openapi.ui.popup.JBPopupFactory; import com.intellij.openapi.ui.popup.PopupStep; import com.intellij.openapi.ui.popup.util.BaseListPopupStep; import com.intellij.util.containers.ContainerUtil; +import com.intellij.util.ui.UIUtil; import com.intellij.util.ui.update.Activatable; import com.intellij.util.ui.update.UiNotifyConnector; -import com.intellij.xml.util.XmlStringUtil; import org.jetbrains.annotations.NotNull; import javax.swing.*; +import java.awt.*; import java.awt.event.ActionEvent; import java.awt.event.ActionListener; import java.util.List; @@ -36,14 +38,18 @@ import java.util.List; * @author nik */ public class ArtifactErrorPanel { - private JPanel myMainPanel; - private JButton myFixButton; - private JLabel myErrorLabel; + private final JPanel myMainPanel; + private final JButton myFixButton; + private final JLabel myErrorLabel; private List myCurrentQuickFixes; private String myErrorText; public ArtifactErrorPanel(final ArtifactEditorImpl artifactEditor) { - myErrorLabel.setIcon(AllIcons.RunConfigurations.ConfigurationWarning); + myMainPanel = new JPanel(new BorderLayout()); + myErrorLabel = new JLabel(); + myMainPanel.add(myErrorLabel, BorderLayout.CENTER); + myFixButton = new JButton(); + myMainPanel.add(myFixButton, BorderLayout.EAST); new UiNotifyConnector(myMainPanel, new Activatable.Adapter() { @Override public void showNotify() { @@ -86,9 +92,12 @@ public class ArtifactErrorPanel { artifactEditor.queueValidation(); } - public void showError(@NotNull String message, @NotNull List quickFixes) { + public void showError(@NotNull String message, @NotNull ProjectStructureProblemType.Severity severity, + @NotNull List quickFixes) { myErrorLabel.setVisible(true); - final String errorText = XmlStringUtil.wrapInHtml(message); + myErrorLabel.setIcon(severity == ProjectStructureProblemType.Severity.ERROR ? AllIcons.General.Error : + severity == ProjectStructureProblemType.Severity.WARNING ? AllIcons.General.Warning : AllIcons.General.Information); + final String errorText = UIUtil.toHtml(message); if (myErrorLabel.isShowing()) { myErrorLabel.setText(errorText); } diff --git a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactValidationManagerImpl.java b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactValidationManagerImpl.java index 966abe6b413c..b29600682608 100644 --- a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactValidationManagerImpl.java +++ b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/ArtifactValidationManagerImpl.java @@ -83,7 +83,7 @@ public class ArtifactValidationManagerImpl implements Disposable { showProblemInTree(artifactProblem); } } - myErrorPanel.showError(message, quickFixes); + myErrorPanel.showError(message, description.getSeverity(), quickFixes); } } }