From 6763926fe969b28fb1b56ba3e8992a4b865bc032 Mon Sep 17 00:00:00 2001 From: Mikhail Golubev Date: Fri, 21 Nov 2025 11:37:20 +0200 Subject: [PATCH] PY-85270 Remove a test that doesn't make sense anymore Now, if there are matching variants from other contributors (e.g. keyword argument names), we don't suggest importable modules and packages at all. GitOrigin-RevId: 983e6bd5b7afd0d7895cdfe2d26c3282642f97a8 --- .../NonImportedModulesSuggestedLast/config.py | 0 .../NonImportedModulesSuggestedLast/contrib.py | 0 .../NonImportedModulesSuggestedLast/main.py | 4 ---- .../python/PyNotImportedQualifiedNameCompletionTest.java | 5 ----- 4 files changed, 9 deletions(-) delete mode 100644 python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/config.py delete mode 100644 python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/contrib.py delete mode 100644 python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/main.py diff --git a/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/config.py b/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/config.py deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/contrib.py b/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/contrib.py deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/main.py b/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/main.py deleted file mode 100644 index 877dbed9236a..000000000000 --- a/python/testData/completion/notImportedQualifiedName/NonImportedModulesSuggestedLast/main.py +++ /dev/null @@ -1,4 +0,0 @@ -def func(configuration=): - pass - -func(con) diff --git a/python/testSrc/com/jetbrains/python/PyNotImportedQualifiedNameCompletionTest.java b/python/testSrc/com/jetbrains/python/PyNotImportedQualifiedNameCompletionTest.java index f096e98aa93f..be5ae9b4c04b 100644 --- a/python/testSrc/com/jetbrains/python/PyNotImportedQualifiedNameCompletionTest.java +++ b/python/testSrc/com/jetbrains/python/PyNotImportedQualifiedNameCompletionTest.java @@ -179,11 +179,6 @@ public class PyNotImportedQualifiedNameCompletionTest extends PyTestCase { assertEquals(1, ContainerUtil.count(variants, "foo"::equals)); } - // PY-47962 - public void testNonImportedModulesSuggestedLast() { - assertNull(doBasicCompletion()); - } - // PY-47962 public void testModuleNamesWithMiddleMatchNotSuggested() { List variants = doBasicCompletion();