From 65b0798255411d69da4b7bf5e4ba0cd08191551b Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Tue, 29 Nov 2016 11:03:51 +0100 Subject: [PATCH] class may be interface: accept constructors with empty statements and calls to Object::super (IDEA-CR-16345) --- .../ig/classlayout/ClassMayBeInterfaceInspection.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassMayBeInterfaceInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassMayBeInterfaceInspection.java index 7f12362aaad1..3c277e36f0d1 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassMayBeInterfaceInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassMayBeInterfaceInspection.java @@ -32,6 +32,7 @@ import com.siyeh.ig.BaseInspectionVisitor; import com.siyeh.ig.InspectionGadgetsFix; import com.siyeh.ig.memory.InnerClassReferenceVisitor; import com.siyeh.ig.psiutils.ClassUtils; +import com.siyeh.ig.psiutils.MethodUtils; import org.jdom.Element; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -198,13 +199,7 @@ public class ClassMayBeInterfaceInspection extends BaseInspection { } private static boolean isEmptyConstructor(@NotNull PsiMethod method) { - if (method.isConstructor()) { - PsiCodeBlock body = method.getBody(); - if (body != null && body.getStatements().length == 0 && method.getDocComment() == null) { - return true; - } - } - return false; + return method.isConstructor() && MethodUtils.isTrivial(method, false); } private class ClassMayBeInterfaceVisitor extends BaseInspectionVisitor {