From 647035e5349b426dab0d20206665feffa03bf6c4 Mon Sep 17 00:00:00 2001 From: Max Medvedev Date: Wed, 21 Jan 2026 14:40:51 +0100 Subject: [PATCH] IJPL-207762 run completion insertion on both frontend and backend Space-RevId: 13405e6a75440c39a5ab36e98f582d0d6be3110f GitOrigin-RevId: 13d987fb93a215c4a1a1d3c7c16b1c5bc54ed249 --- platform/lang-impl/api-dump-unreviewed.txt | 2 +- .../lookup/impl/actions/ChooseItemAction.java | 16 ++-------------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/platform/lang-impl/api-dump-unreviewed.txt b/platform/lang-impl/api-dump-unreviewed.txt index fd4a6251cda5..324bf23e7dff 100644 --- a/platform/lang-impl/api-dump-unreviewed.txt +++ b/platform/lang-impl/api-dump-unreviewed.txt @@ -4401,8 +4401,8 @@ f:com.intellij.codeInsight.lookup.impl.LookupTypedHandler - execute(com.intellij.openapi.editor.Editor,C,com.intellij.openapi.actionSystem.DataContext):V - s:getLookupAction(C,com.intellij.codeInsight.lookup.impl.LookupImpl):com.intellij.codeInsight.lookup.CharFilter$Result a:com.intellij.codeInsight.lookup.impl.actions.ChooseItemAction -- com.intellij.codeInsight.hint.HintManagerImpl$ActionToIgnore - com.intellij.openapi.editor.actionSystem.EditorAction +- com.intellij.codeInsight.hint.HintManagerImpl$ActionToIgnore - com.intellij.openapi.editor.actionSystem.LatencyAwareEditorAction - (com.intellij.codeInsight.lookup.impl.actions.ChooseItemAction$Handler):V - s:hasTemplatePrefix(com.intellij.codeInsight.lookup.impl.LookupImpl,C):Z diff --git a/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/actions/ChooseItemAction.java b/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/actions/ChooseItemAction.java index d155adfdf99c..dfe22c09edf6 100644 --- a/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/actions/ChooseItemAction.java +++ b/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/actions/ChooseItemAction.java @@ -1,10 +1,9 @@ -// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. +// Copyright 2000-2026 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. package com.intellij.codeInsight.lookup.impl.actions; import com.intellij.codeInsight.completion.CompletionProcess; import com.intellij.codeInsight.completion.CompletionService; -import com.intellij.codeInsight.completion.actions.CodeCompletionAction; import com.intellij.codeInsight.hint.HintManagerImpl; import com.intellij.codeInsight.lookup.Lookup; import com.intellij.codeInsight.lookup.LookupFocusDegree; @@ -14,8 +13,6 @@ import com.intellij.codeInsight.template.TemplateActionContext; import com.intellij.codeInsight.template.impl.*; import com.intellij.codeInsight.template.impl.editorActions.ExpandLiveTemplateCustomAction; import com.intellij.openapi.actionSystem.DataContext; -import com.intellij.openapi.actionSystem.remoting.ActionRemoteBehavior; -import com.intellij.openapi.actionSystem.remoting.ActionRemoteBehaviorSpecification; import com.intellij.openapi.editor.Caret; import com.intellij.openapi.editor.Editor; import com.intellij.openapi.editor.actionSystem.EditorAction; @@ -24,25 +21,16 @@ import com.intellij.openapi.editor.actionSystem.LatencyAwareEditorAction; import com.intellij.psi.PsiDocumentManager; import com.intellij.psi.PsiFile; import com.intellij.util.containers.ContainerUtil; -import org.jetbrains.annotations.ApiStatus; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import java.util.List; -public abstract class ChooseItemAction extends EditorAction implements HintManagerImpl.ActionToIgnore, - LatencyAwareEditorAction, - ActionRemoteBehaviorSpecification { +public abstract class ChooseItemAction extends EditorAction implements HintManagerImpl.ActionToIgnore, LatencyAwareEditorAction { public ChooseItemAction(Handler handler) { super(handler); } - @Override - @ApiStatus.Internal - public final @Nullable ActionRemoteBehavior getBehavior() { - return CodeCompletionAction.getCompletionBehavior(); - } - public static class Handler extends EditorActionHandler { final boolean focusedOnly; final char finishingChar;