From 63c8f010cac1be2aeb07821fbd51720c00c614b0 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Wed, 18 Feb 2015 19:04:55 +0100 Subject: [PATCH] IG: compile time constants may be 'static' even if they are contained in an anonymous class --- .../com/siyeh/ig/performance/FieldMayBeStaticInspection.java | 2 +- .../performance/field_may_be_static/FieldMayBeStatic.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/FieldMayBeStaticInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/FieldMayBeStaticInspection.java index c3a3bacc2596..40b06c127967 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/FieldMayBeStaticInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/FieldMayBeStaticInspection.java @@ -81,7 +81,7 @@ public class FieldMayBeStaticInspection extends BaseInspection { // inner class cannot have static declarations return; } - if (containingClass instanceof PsiAnonymousClass) { + if (containingClass instanceof PsiAnonymousClass && !PsiUtil.isCompileTimeConstant(field)) { return; } if (!canBeStatic(initializer)) { diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/performance/field_may_be_static/FieldMayBeStatic.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/performance/field_may_be_static/FieldMayBeStatic.java index f354cb0769d1..05e8c9000b73 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/performance/field_may_be_static/FieldMayBeStatic.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/performance/field_may_be_static/FieldMayBeStatic.java @@ -19,6 +19,7 @@ public class FieldMayBeStatic public void run() { new Namer() { + final String constant = ""; final String usage = "Usage: " + getString(); public void action() {