From 62c3cf2dfa2fc71e16904d92b67287bdf2d0f376 Mon Sep 17 00:00:00 2001 From: Ekaterina Tuzova Date: Wed, 23 Mar 2011 17:56:05 +0300 Subject: [PATCH] fixed PY-3121 "Statement has no effect" inspection should not react on statements that contain error elements --- .../python/inspections/PyStatementEffectInspection.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/python/src/com/jetbrains/python/inspections/PyStatementEffectInspection.java b/python/src/com/jetbrains/python/inspections/PyStatementEffectInspection.java index 8a06bbba7e16..97dbcdc23919 100644 --- a/python/src/com/jetbrains/python/inspections/PyStatementEffectInspection.java +++ b/python/src/com/jetbrains/python/inspections/PyStatementEffectInspection.java @@ -50,6 +50,8 @@ public class PyStatementEffectInspection extends PyInspection { return; } final PyExpression expression = node.getExpression(); + if (PsiTreeUtil.hasErrorElements(expression)) + return; if (hasEffect(expression)) return; final PyTryPart tryPart = PsiTreeUtil.getParentOfType(node, PyTryPart.class); @@ -62,7 +64,8 @@ public class PyStatementEffectInspection extends PyInspection { return; } } - registerProblem(expression, "Statement seems to have no effect", new StatementEffectIntroduceVariableQuickFix(expression)); + registerProblem(expression, "Statement seems to have no effect", + new StatementEffectIntroduceVariableQuickFix(expression)); } private boolean hasEffect(@Nullable PyExpression expression) {