From 6228ac9b2aec7e483e347215c2b0eb94ccd9ea39 Mon Sep 17 00:00:00 2001 From: Nikolay Chashnikov Date: Tue, 18 Mar 2025 22:21:05 +0300 Subject: [PATCH] [dev] show precise parent classloaders in the plugin descriptors dump The 'getAllParentsClassLoaders' returns the list which is actually used why loading classes, so it's more correct than taking classloaders from the '_getParents' method. Also, the latter often showed many duplicating entries making it harder to read the dump. GitOrigin-RevId: 9526a7e5d7b327f03ce0f122c75ff7e1e14a3017 --- .../src/com/intellij/internal/DumpPluginDescriptorsAction.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/internal/DumpPluginDescriptorsAction.kt b/platform/lang-impl/src/com/intellij/internal/DumpPluginDescriptorsAction.kt index 1d466c607583..5eebe6dc3d5f 100644 --- a/platform/lang-impl/src/com/intellij/internal/DumpPluginDescriptorsAction.kt +++ b/platform/lang-impl/src/com/intellij/internal/DumpPluginDescriptorsAction.kt @@ -162,9 +162,7 @@ private class DumpPluginDescriptorsAction : DumbAwareAction() { if (printedClassLoaders.add(classLoader)) { @Suppress("TestOnlyProblems") val parents = when (classLoader) { - is PluginClassLoader -> classLoader._getParents().map { it.classLoader }.ifEmpty { - listOf(ClassLoaderConfigurator::class.java.classLoader) - } + is PluginClassLoader -> classLoader.getAllParentsClassLoaders().toList() else -> listOf(classLoader.parent) } writeArrayFieldStart("parents")