From 5ee15774213ef6351f4516e02d2bb2d5c2253df1 Mon Sep 17 00:00:00 2001 From: irengrig Date: Tue, 6 Dec 2011 16:59:47 +0400 Subject: [PATCH] ++ IDEA-78314 SVN; Commit doesn't happen: prevent pre-commit check runtime exception from killing to parent commit process --- .../com/intellij/openapi/vcs/impl/CodeSmellDetectorImpl.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/openapi/vcs/impl/CodeSmellDetectorImpl.java b/platform/lang-impl/src/com/intellij/openapi/vcs/impl/CodeSmellDetectorImpl.java index df325bc3ee6a..e2f41687efe4 100644 --- a/platform/lang-impl/src/com/intellij/openapi/vcs/impl/CodeSmellDetectorImpl.java +++ b/platform/lang-impl/src/com/intellij/openapi/vcs/impl/CodeSmellDetectorImpl.java @@ -112,10 +112,9 @@ public class CodeSmellDetectorImpl extends CodeSmellDetector { boolean completed = ProgressManager.getInstance().runProcessWithProgressSynchronously(new Runnable() { public void run() { - int i = 0; try { @Nullable final ProgressIndicator progress = ProgressManager.getInstance().getProgressIndicator(); - for (; i < filesToCheck.size(); i++) { + for (int i = 0; i < filesToCheck.size(); i++) { if (progress != null && progress.isCanceled()) throw new ProcessCanceledException(); @@ -134,7 +133,6 @@ public class CodeSmellDetectorImpl extends CodeSmellDetector { result.addAll(codeSmells); } } - throw new NullPointerException(); } } catch (Exception e) { LOG.error(e);