From 5db3adb4f59b1c257e348ae0d7e3878c367a7211 Mon Sep 17 00:00:00 2001
From: Bas Leijdekkers <basleijdekkers@gmail.com>
Date: Wed, 24 Sep 2014 14:55:45 +0200
Subject: [PATCH] correct check that all constructors are private for "Class
 with only 'private' constructors should be declared 'final'" inspection

---
 .../ClassWithOnlyPrivateConstructorsInspectionBase.java     | 2 +-
 .../ClassWithOnlyPrivateConstructorsInspectionTest.java     | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java
index b6583b4ede75..eadea548cb99 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java
@@ -62,7 +62,7 @@ public class ClassWithOnlyPrivateConstructorsInspectionBase extends BaseInspecti
         return;
       }
       for (PsiMethod constructor : constructors) {
-        if (constructor.hasModifierProperty(PsiModifier.FINAL)) {
+        if (!constructor.hasModifierProperty(PsiModifier.PRIVATE)) {
           return;
         }
       }
diff --git a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java
index 397a2fe1d37e..b26ebd51d4e8 100644
--- a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java
+++ b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java
@@ -49,6 +49,12 @@ public class ClassWithOnlyPrivateConstructorsInspectionTest extends LightInspect
            "}");
   }
 
+  public void testPublicConstructor() {
+    doTest("class A {" +
+           "  public A() {}" +
+           "}");
+  }
+
   @Nullable
   @Override
   protected InspectionProfileEntry getInspection() {