diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java index b6583b4ede75..eadea548cb99 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionBase.java @@ -62,7 +62,7 @@ public class ClassWithOnlyPrivateConstructorsInspectionBase extends BaseInspecti return; } for (PsiMethod constructor : constructors) { - if (constructor.hasModifierProperty(PsiModifier.FINAL)) { + if (!constructor.hasModifierProperty(PsiModifier.PRIVATE)) { return; } } diff --git a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java index 397a2fe1d37e..b26ebd51d4e8 100644 --- a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java +++ b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/classlayout/ClassWithOnlyPrivateConstructorsInspectionTest.java @@ -49,6 +49,12 @@ public class ClassWithOnlyPrivateConstructorsInspectionTest extends LightInspect "}"); } + public void testPublicConstructor() { + doTest("class A {" + + " public A() {}" + + "}"); + } + @Nullable @Override protected InspectionProfileEntry getInspection() {