diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java index 2ceaad14bfe5..8e0d86f0d325 100644 --- a/plugins/InspectionGadgets/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java +++ b/plugins/InspectionGadgets/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java @@ -168,8 +168,7 @@ public class UnnecessarilyQualifiedInnerClassAccessInspection visitReferenceElement(expression); } - private boolean isReferenceToTarget( - String referenceText, PsiClass target, PsiElement context) { + private boolean isReferenceToTarget(String referenceText, PsiClass target, PsiElement context) { final PsiManager manager = target.getManager(); final JavaPsiFacade facade = JavaPsiFacade.getInstance(manager.getProject()); @@ -177,8 +176,7 @@ public class UnnecessarilyQualifiedInnerClassAccessInspection final PsiClass referencedClass = resolveHelper.resolveReferencedClass(referenceText, context); - return referencedClass == null || - manager.areElementsEquivalent(target, referencedClass); + return manager.areElementsEquivalent(target, referencedClass); } private boolean isInImportOrPackage(PsiElement element) { diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/Test.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/Test.java index 5c0065f525c8..932c8a2ab670 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/Test.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/Test.java @@ -29,4 +29,11 @@ public class Test { } @interface Y { Class value(); -} \ No newline at end of file +} + +class Foo extends PresenterWidget { //no warning as Bar here is not accessible + interface Bar extends View { } +} + +interface View {} +class PresenterWidget{} \ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/expected.xml b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/expected.xml index bcdeef45f4de..cc3a3bca2221 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/expected.xml +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_inner_class_access/expected.xml @@ -1,19 +1,5 @@ - - - Test.java - 3 - Unnecessarily qualified inner class access - 'X' is unnecessarily qualified with <code>Test</code> #loc - - - - Test.java - 7 - Unnecessarily qualified inner class access - 'Entry' is unnecessarily qualified with <code>Map</code> #loc - Test.java