From 5d0de6c9ef8f81f6f5376d33df7d494e392563de Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Thu, 23 Sep 2010 11:14:03 +0200 Subject: [PATCH] fix serializable has serial version uid test --- .../SerializableHasSerialVersionUIDField.html | 2 +- .../SerializableHasSerialVersionUIDField.java | 2 +- .../expected.xml | 10 +++++++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/plugins/InspectionGadgets/src/inspectionDescriptions/SerializableHasSerialVersionUIDField.html b/plugins/InspectionGadgets/src/inspectionDescriptions/SerializableHasSerialVersionUIDField.html index 655e12ea868c..9e4b443d9373 100644 --- a/plugins/InspectionGadgets/src/inspectionDescriptions/SerializableHasSerialVersionUIDField.html +++ b/plugins/InspectionGadgets/src/inspectionDescriptions/SerializableHasSerialVersionUIDField.html @@ -1,7 +1,7 @@
-This inspection reports any instances of Serializable classes which do not provide a serialVersionUID field. +This inspection reports any Serializable classes which do not provide a serialVersionUID field. Without a serialVersionUID field, any change to a class will make previously serialized versions unreadable.

Use the table below to specify what specific classes and inheritors should be excluded diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/SerializableHasSerialVersionUIDField.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/SerializableHasSerialVersionUIDField.java index d3d5d7eb74a6..f7ff69e3cc70 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/SerializableHasSerialVersionUIDField.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/SerializableHasSerialVersionUIDField.java @@ -5,7 +5,7 @@ import java.io.Serializable; public class SerializableHasSerialVersionUIDField implements Serializable { - public abstract class DoNotWarnOnMe implements Serializable { } + public abstract class DoWarnOnMe implements Serializable { } public interface X extends Serializable {} } \ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/expected.xml b/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/expected.xml index 09f8512070fa..59aa14775325 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/expected.xml +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/serialization/serializable_has_serial_version_uid_field/expected.xml @@ -1,10 +1,18 @@ - + SerializableHasSerialVersionUIDField.java 5 Serializable class without 'serialVersionUID' <code>SerializableHasSerialVersionUIDField</code> does not define a 'serialVersionUID' field #loc + + + SerializableHasSerialVersionUIDField.java + 8 + Serializable class without 'serialVersionUID' + <code>DoNotWarnOnMe</code> does not define a 'serialVersionUID' field #loc + + \ No newline at end of file