From 5b277139f3a0c5002b1555deaf0796d35ccb58d3 Mon Sep 17 00:00:00 2001 From: Anton Makeev Date: Mon, 4 Jan 2016 14:45:50 +0100 Subject: [PATCH] ConsoleHistory: small optimization --- .../execution/console/ConsoleHistoryController.java | 4 ++-- .../com/intellij/execution/console/ConsoleHistoryModel.java | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryController.java b/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryController.java index 2555d03800c6..dc6040e4a300 100644 --- a/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryController.java +++ b/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryController.java @@ -136,7 +136,7 @@ public class ConsoleHistoryController { } public boolean hasHistory() { - return !getModel().getEntries().isEmpty(); + return !getModel().isEmpty(); } @NotNull @@ -555,7 +555,7 @@ public class ConsoleHistoryController { private void saveHistory() { try { - if (getModel().getEntries().isEmpty()) return; + if (getModel().isEmpty()) return; if (myRootType.isHidden()) { saveHistoryOld(); return; diff --git a/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryModel.java b/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryModel.java index 6ddc0a22a801..3fed26ec932a 100644 --- a/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryModel.java +++ b/platform/lang-impl/src/com/intellij/execution/console/ConsoleHistoryModel.java @@ -96,6 +96,12 @@ class ConsoleHistoryModel extends SimpleModificationTracker { } } + public boolean isEmpty() { + synchronized (myLock) { + return myEntries.isEmpty(); + } + } + public int getHistorySize() { synchronized (myLock) { return myEntries.size();