From 5a99697c4cea43f3d59c1ff1b0e78a4c00a25920 Mon Sep 17 00:00:00 2001 From: Dmitry Avdeev Date: Thu, 15 Aug 2013 16:53:54 +0400 Subject: [PATCH] better Groovy SDK notification fix --- .../src/com/intellij/openapi/util/text/StringUtil.java | 1 - .../gradle/config/GradleLibraryPresentationProvider.java | 5 ++--- .../DefaultGroovyFrameworkConfigNotification.java | 8 +++----- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/platform/util/src/com/intellij/openapi/util/text/StringUtil.java b/platform/util/src/com/intellij/openapi/util/text/StringUtil.java index 82bd5a4a1f95..afafbafdcdb7 100644 --- a/platform/util/src/com/intellij/openapi/util/text/StringUtil.java +++ b/platform/util/src/com/intellij/openapi/util/text/StringUtil.java @@ -248,7 +248,6 @@ public class StringUtil extends StringUtilRt { return html.replaceAll("<(.|\n)*?>", ""); } - @Nullable public static String toLowerCase(@Nullable final String str) { //noinspection ConstantConditions return str == null ? null : str.toLowerCase(); diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/config/GradleLibraryPresentationProvider.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/config/GradleLibraryPresentationProvider.java index c9ec84692505..c3036d296e06 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/config/GradleLibraryPresentationProvider.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/config/GradleLibraryPresentationProvider.java @@ -15,7 +15,6 @@ */ package org.jetbrains.plugins.gradle.config; -import com.intellij.openapi.externalSystem.util.ExternalSystemBundle; import com.intellij.openapi.roots.OrderRootType; import com.intellij.openapi.roots.libraries.LibraryKind; import com.intellij.openapi.roots.ui.configuration.libraryEditor.LibraryEditor; @@ -26,8 +25,8 @@ import icons.GradleIcons; import org.jetbrains.annotations.Nls; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; -import org.jetbrains.plugins.gradle.util.GradleConstants; import org.jetbrains.plugins.gradle.service.GradleInstallationManager; +import org.jetbrains.plugins.gradle.util.GradleConstants; import org.jetbrains.plugins.groovy.config.GroovyLibraryPresentationProviderBase; import javax.swing.*; @@ -90,7 +89,7 @@ public class GradleLibraryPresentationProvider extends GroovyLibraryPresentation @NotNull @Override public String getLibraryCategoryName() { - return ExternalSystemBundle.message(GradleConstants.SYSTEM_ID.getReadableName()); + return "Gradle"; } @Override diff --git a/plugins/groovy/src/org/jetbrains/plugins/groovy/annotator/DefaultGroovyFrameworkConfigNotification.java b/plugins/groovy/src/org/jetbrains/plugins/groovy/annotator/DefaultGroovyFrameworkConfigNotification.java index bad8a50933cd..eee671f4f1e4 100644 --- a/plugins/groovy/src/org/jetbrains/plugins/groovy/annotator/DefaultGroovyFrameworkConfigNotification.java +++ b/plugins/groovy/src/org/jetbrains/plugins/groovy/annotator/DefaultGroovyFrameworkConfigNotification.java @@ -15,13 +15,14 @@ */ package org.jetbrains.plugins.groovy.annotator; -import com.intellij.ide.util.frameworkSupport.AddFrameworkSupportDialog; import com.intellij.openapi.module.Module; import com.intellij.openapi.roots.libraries.Library; +import com.intellij.openapi.roots.ui.configuration.libraries.AddCustomLibraryDialog; import com.intellij.ui.EditorNotificationPanel; import org.jetbrains.annotations.NotNull; import org.jetbrains.plugins.groovy.GroovyBundle; import org.jetbrains.plugins.groovy.config.GroovyConfigUtils; +import org.jetbrains.plugins.groovy.config.GroovyLibraryDescription; /** * @author sergey.evdokimov @@ -46,10 +47,7 @@ public class DefaultGroovyFrameworkConfigNotification extends GroovyFrameworkCon panel.createActionLabel(GroovyBundle.message("configure.groovy.library"), new Runnable() { @Override public void run() { - AddFrameworkSupportDialog dialog = AddFrameworkSupportDialog.createDialog(module); - if (dialog != null) { - dialog.show(); - } + AddCustomLibraryDialog.createDialog(new GroovyLibraryDescription(), module, null).show(); } }); return panel;