From 59d9a71d6c7bc034e49b61ad2c2c3e99ce709ba9 Mon Sep 17 00:00:00 2001 From: anna Date: Wed, 23 Oct 2013 19:54:07 +0200 Subject: [PATCH] testng: accept non-recursive package declarations (IDEA-113479) --- .../testng/inspection/UndeclaredTestInspection.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/testng/src/com/theoryinpractice/testng/inspection/UndeclaredTestInspection.java b/plugins/testng/src/com/theoryinpractice/testng/inspection/UndeclaredTestInspection.java index 5fbf7f1f77ef..a5b3a578c424 100644 --- a/plugins/testng/src/com/theoryinpractice/testng/inspection/UndeclaredTestInspection.java +++ b/plugins/testng/src/com/theoryinpractice/testng/inspection/UndeclaredTestInspection.java @@ -27,6 +27,7 @@ import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.fileChooser.FileChooser; import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory; import com.intellij.openapi.project.Project; +import com.intellij.openapi.util.text.StringUtil; import com.intellij.openapi.vfs.LocalFileSystem; import com.intellij.openapi.vfs.VirtualFile; import com.intellij.psi.*; @@ -79,7 +80,7 @@ public class UndeclaredTestInspection extends BaseJavaLocalInspectionTool { final Project project = aClass.getProject(); final String qName = aClass.getQualifiedName(); if (qName == null) return null; - + final String packageQName = StringUtil.getPackageName(qName); final List names = new ArrayList(); for(int i = 0; i < qName.length(); i++) { if (qName.charAt(i) == '.') { @@ -105,7 +106,7 @@ public class UndeclaredTestInspection extends BaseJavaLocalInspectionTool { if (attribute == null) return true; final String value = attribute.getValue(); if (value == null) return true; - if (!value.endsWith(".*")) return true; + if (!value.endsWith(".*") && !value.equals(packageQName)) return true; } found[0] = true; return false;