From 598cab9b2b2c955276ddb4d95da492643d584726 Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Mon, 12 Dec 2016 15:18:09 +0100 Subject: [PATCH] cleanup --- .../openapi/actionSystem/ex/ActionUtil.java | 4 ++-- .../keymap/impl/IdeKeyEventDispatcher.java | 15 ++------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/platform/platform-api/src/com/intellij/openapi/actionSystem/ex/ActionUtil.java b/platform/platform-api/src/com/intellij/openapi/actionSystem/ex/ActionUtil.java index bec45fae330a..55b9fce0057d 100644 --- a/platform/platform-api/src/com/intellij/openapi/actionSystem/ex/ActionUtil.java +++ b/platform/platform-api/src/com/intellij/openapi/actionSystem/ex/ActionUtil.java @@ -27,6 +27,7 @@ import com.intellij.openapi.util.registry.Registry; import com.intellij.openapi.util.text.StringUtil; import com.intellij.util.ObjectUtils; import com.intellij.util.PausesStat; +import com.intellij.util.containers.ContainerUtil; import com.intellij.util.ui.UIUtil; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; @@ -35,7 +36,6 @@ import org.jetbrains.annotations.Nullable; import javax.swing.*; import java.awt.event.ActionListener; import java.util.ArrayList; -import java.util.Collections; import java.util.List; public class ActionUtil { @@ -227,7 +227,7 @@ public class ActionUtil { @NotNull public static List getActions(@NotNull JComponent component) { - return ObjectUtils.notNull(UIUtil.getClientProperty(component, AnAction.ACTIONS_KEY), Collections.emptyList()); + return ContainerUtil.notNullize(UIUtil.getClientProperty(component, AnAction.ACTIONS_KEY)); } public static void clearActions(@NotNull JComponent component) { diff --git a/platform/platform-impl/src/com/intellij/openapi/keymap/impl/IdeKeyEventDispatcher.java b/platform/platform-impl/src/com/intellij/openapi/keymap/impl/IdeKeyEventDispatcher.java index 2e1c6d3091e6..dd615b416513 100644 --- a/platform/platform-impl/src/com/intellij/openapi/keymap/impl/IdeKeyEventDispatcher.java +++ b/platform/platform-impl/src/com/intellij/openapi/keymap/impl/IdeKeyEventDispatcher.java @@ -64,7 +64,6 @@ import com.intellij.util.ui.MacUIUtil; import com.intellij.util.ui.UIUtil; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; import javax.swing.*; import javax.swing.plaf.basic.ComboPopup; @@ -652,7 +651,6 @@ public final class IdeKeyEventDispatcher implements Disposable { boolean hasSecondStroke = false; // here we try to find "local" shortcuts - for (; component != null; component = component.getParent()) { if (!(component instanceof JComponent)) { continue; @@ -661,11 +659,7 @@ public final class IdeKeyEventDispatcher implements Disposable { if (listOfActions.isEmpty()) { continue; } - for (Object listOfAction : listOfActions) { - if (!(listOfAction instanceof AnAction)) { - continue; - } - AnAction action = (AnAction)listOfAction; + for (AnAction action : listOfActions) { hasSecondStroke |= addAction(action, sc); } // once we've found a proper local shortcut(s), we continue with non-local shortcuts @@ -676,10 +670,8 @@ public final class IdeKeyEventDispatcher implements Disposable { } // search in main keymap - Keymap keymap = KeymapManager.getInstance().getActiveKeymap(); String[] actionIds = keymap.getActionIds(sc); - ActionManager actionManager = ActionManager.getInstance(); for (String actionId : actionIds) { AnAction action = actionManager.getAction(actionId); @@ -700,10 +692,8 @@ public final class IdeKeyEventDispatcher implements Disposable { final KeyStroke secondKeyStroke = keyboardShortcut.getSecondKeyStroke(); if (secondKeyStroke != null && secondKeyStroke.getModifiers() != 0 && firstKeyStroke.getModifiers() != 0) { - final KeyboardShortcut altShortCut = new KeyboardShortcut(firstKeyStroke, KeyStroke - .getKeyStroke(secondKeyStroke.getKeyCode(), 0)); + final KeyboardShortcut altShortCut = new KeyboardShortcut(firstKeyStroke, KeyStroke.getKeyStroke(secondKeyStroke.getKeyCode(), 0)); final String[] additionalActions = keymap.getActionIds(altShortCut); - for (final String actionId : additionalActions) { AnAction action = actionManager.getAction(actionId); if (action != null) { @@ -714,7 +704,6 @@ public final class IdeKeyEventDispatcher implements Disposable { } } } - } myContext.setHasSecondStroke(hasSecondStroke);