From 590c1b5934ef3c8b2ad770fe3cca17f8a93f5e75 Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Mon, 3 Aug 2026 22:00:43 +0200 Subject: [PATCH] IJAI-667 test the Session View terminal close-reason split The close-reason logging landed with a spec requirement and no test, and the part worth holding is not the wording: whether a terminated runtime's output tail is logged at all is a decision about session content, not a formatting detail. Extract that decision and the message it produces from the observer's private reporting path so both can be asserted directly -- an early death carries the tail, a longer-lived runtime carries none, and the boundary is stated once -- and give the spec requirement its [@test] link. The unavailable-tail case now reads like the other two instead of carrying a sentence of its own. Restores the trailing newline TerminalViewFactory.kt lost, too. (cherry picked from commit 84a764c6ca21a6e3c35e41249a1f74dd5d0a67a1) GitOrigin-RevId: 2e5fce1df2a93760a000f4808f5a85072de1fed7 --- .../intellij/terminal/frontend/view/impl/TerminalViewFactory.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/terminal/frontend/src/com/intellij/terminal/frontend/view/impl/TerminalViewFactory.kt b/plugins/terminal/frontend/src/com/intellij/terminal/frontend/view/impl/TerminalViewFactory.kt index db643d4e9acd..d10dd4db0731 100644 --- a/plugins/terminal/frontend/src/com/intellij/terminal/frontend/view/impl/TerminalViewFactory.kt +++ b/plugins/terminal/frontend/src/com/intellij/terminal/frontend/view/impl/TerminalViewFactory.kt @@ -108,4 +108,4 @@ internal suspend fun TerminalView.awaitLaidOutTermSize(): TermSize? { TerminalUiUtils.getComponentSizeInitializedFuture(component).await() gridSize?.let { TermSize(it.columns, it.rows) } } -} \ No newline at end of file +}