From 58a3377455853d76eff5e0a201565a39b7dfdccc Mon Sep 17 00:00:00 2001
From: Bas Leijdekkers <basleijdekkers@gmail.com>
Date: Tue, 11 Mar 2014 18:15:45 +0100
Subject: [PATCH] IDEA-121920 (X/X can be replaced with X - incorrect
 arithmetic)

---
 .../numeric/PointlessArithmeticExpressionInspection.java   | 2 +-
 .../PointlessArithmeticExpression.java                     | 2 ++
 .../numeric/pointless_arithmetic_expression/expected.xml   | 7 +++++++
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/PointlessArithmeticExpressionInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/PointlessArithmeticExpressionInspection.java
index 57af5357f27a..9874e3cddb5d 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/PointlessArithmeticExpressionInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/PointlessArithmeticExpressionInspection.java
@@ -120,7 +120,7 @@ public class PointlessArithmeticExpressionInspection
       }
     }
     else if (tokenType.equals(JavaTokenType.DIV)) {
-      if (ExpressionUtils.isOne(expression)) {
+      if (ExpressionUtils.isOne(rhs)) {
         return lhs.getText();
       }
       return "1";
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/PointlessArithmeticExpression.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/PointlessArithmeticExpression.java
index 5f6231d91802..eaea1bbbdd76 100644
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/PointlessArithmeticExpression.java
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/PointlessArithmeticExpression.java
@@ -110,4 +110,6 @@ class Main {
     final Main main = new Main(12);
     return (CONST + (new Main(5).i) * 8) - (Main.CONST + new Main(5).i * (8));
   }
+
+  int one = 5/5;
 }
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/expected.xml b/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/expected.xml
index 84ac4f27ddd1..b34b0147fd2f 100644
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/expected.xml
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/numeric/pointless_arithmetic_expression/expected.xml
@@ -147,4 +147,11 @@
     <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Pointless arithmetic expression</problem_class>
     <description>&lt;code&gt;(CONST + (new Main(5).i) * 8) - (Main.CONST + new Main(5).i * (8))&lt;/code&gt; can be replaced with '0' #loc</description>
   </problem>
+
+  <problem>
+    <file>PointlessArithmeticExpression.java</file>
+    <line>114</line>
+    <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Pointless arithmetic expression</problem_class>
+    <description>&lt;code&gt;5/5&lt;/code&gt; can be replaced with '1' #loc</description>
+  </problem>
 </problems>
\ No newline at end of file