From 5655b5f7f08b3be4efcc4309c2f10b6e729f08a1 Mon Sep 17 00:00:00 2001
From: Aleksey Pivovarov <AMPivovarov@gmail.com>
Date: Tue, 2 Aug 2016 16:23:15 +0300
Subject: [PATCH] github: do not store password in memory provider if "save
 password" checkbox disabled

* password is stored in GithubAuthDataHolder during the sesion, so we will not ask for password multiple times
* this causes confusing behavior of settings configurable, when password disappears after IDE restart
---
 .../src/org/jetbrains/plugins/github/util/GithubSettings.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plugins/github/src/org/jetbrains/plugins/github/util/GithubSettings.java b/plugins/github/src/org/jetbrains/plugins/github/util/GithubSettings.java
index ad1999ca934f..f5cda6672be7 100644
--- a/plugins/github/src/org/jetbrains/plugins/github/util/GithubSettings.java
+++ b/plugins/github/src/org/jetbrains/plugins/github/util/GithubSettings.java
@@ -170,7 +170,8 @@ public class GithubSettings implements PersistentStateComponent<GithubSettings.S
   }
 
   private void setPassword(@NotNull String password, boolean rememberPassword) {
-    PasswordSafe.getInstance().setPassword(GithubSettings.class, GITHUB_SETTINGS_PASSWORD_KEY, password, !rememberPassword);
+    if (!rememberPassword) return;
+    PasswordSafe.getInstance().setPassword(GithubSettings.class, GITHUB_SETTINGS_PASSWORD_KEY, password);
   }
 
   private static boolean isValidGitAuth(@NotNull GithubAuthData auth) {