From 545251fbea5b369ee7489fbb4064b0b035e55c84 Mon Sep 17 00:00:00 2001
From: Kirill Kirichenko <kirill.kirichenko@jetbrains.com>
Date: Fri, 5 Jun 2020 14:36:38 +0300
Subject: [PATCH] IDEA-238791 Open IW popup on mouse hover and problems view on
 click when problems.view.enabled is set

GitOrigin-RevId: e88b7fdc05d1ba32c9adfeee7f955f10d4cfad3f
---
 .../editor/impl/EditorMarkupModelImpl.java    | 52 ++++++++++++++++++-
 1 file changed, 50 insertions(+), 2 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java
index 76913c1fa88c..98b69312e35b 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java
@@ -52,6 +52,7 @@ import com.intellij.ui.components.labels.LinkLabel;
 import com.intellij.ui.components.panels.NonOpaquePanel;
 import com.intellij.ui.popup.util.PopupState;
 import com.intellij.ui.scale.JBUIScale;
+import com.intellij.util.Alarm;
 import com.intellij.util.IJSwingUtilities;
 import com.intellij.util.ObjectUtils;
 import com.intellij.util.Processor;
@@ -1460,12 +1461,21 @@ public final class EditorMarkupModelImpl extends MarkupModelImpl
     public @NotNull JComponent createCustomComponent(@NotNull Presentation presentation, @NotNull String place) {
       return new StatusButton(this, presentation, new EditorToolbarButtonLook(),
                               place, myEditor.getColorsScheme(),
+                              myPopupManager,
                               () -> showNavigation);
     }
 
     @Override
     public void actionPerformed(@NotNull AnActionEvent e) {
-      myPopupManager.showPopup(e.getInputEvent());
+      if (Experiments.getInstance().isFeatureEnabled("problems.view.enabled")) {
+        myPopupManager.hidePopup();
+        if (analyzerStatus != null) {
+          analyzerStatus.getController().openProblemsView();
+        }
+      }
+      else {
+        myPopupManager.showPopup(e.getInputEvent());
+      }
     }
 
     @Override
@@ -1513,6 +1523,7 @@ public final class EditorMarkupModelImpl extends MarkupModelImpl
     private StatusButton(@NotNull AnAction action, @NotNull Presentation presentation,
                          @NotNull ActionButtonLook buttonLook, @NotNull String place,
                          @NotNull EditorColorsScheme colorsScheme,
+                         @NotNull InspectionPopupManager popupManager,
                          @NotNull BooleanSupplier hasNavButtons) {
       setLayout(new GridBagLayout());
       setOpaque(false);
@@ -1577,12 +1588,18 @@ public final class EditorMarkupModelImpl extends MarkupModelImpl
         @Override
         public void mouseEntered(MouseEvent me) {
           mouseHover = true;
+          if (Experiments.getInstance().isFeatureEnabled("problems.view.enabled")) {
+            popupManager.scheduleShow(me);
+          }
           repaint();
         }
 
         @Override
         public void mouseExited(MouseEvent me) {
           mouseHover = false;
+          if (Experiments.getInstance().isFeatureEnabled("problems.view.enabled")) {
+            popupManager.scheduleHide();
+          }
           repaint();
         }
       };
@@ -1847,8 +1864,10 @@ public final class EditorMarkupModelImpl extends MarkupModelImpl
     private final AncestorListener myAncestorListener;
     private final JBPopupListener myPopupListener;
     private final PopupState myPopupState = new PopupState();
+    private final Alarm popupAlarm = new Alarm();
 
     private JBPopup myPopup;
+    private boolean insidePopup;
 
     private InspectionPopupManager() {
       myContent.setOpaque(true);
@@ -1874,12 +1893,41 @@ public final class EditorMarkupModelImpl extends MarkupModelImpl
           myEditor.getComponent().removeAncestorListener(myAncestorListener);
         }
       };
+
+      myContent.addMouseListener(new MouseAdapter() {
+        @Override
+        public void mouseEntered(MouseEvent event) {
+          insidePopup = true;
+        }
+
+        @Override
+        public void mouseExited(MouseEvent event) {
+          if (!myContent.getBounds().contains(event.getPoint())) {
+            insidePopup = false;
+            hidePopup();
+          }
+        }
+      });
     }
 
     private void updateUI() {
       IJSwingUtilities.updateComponentTreeUI(myContent);
     }
 
+    private void scheduleShow(@NotNull InputEvent event) {
+      popupAlarm.cancelAllRequests();
+      popupAlarm.addRequest(() -> showPopup(event), Registry.intValue("ide.tooltip.initialReshowDelay"));
+    }
+
+    private void scheduleHide() {
+      popupAlarm.cancelAllRequests();
+      popupAlarm.addRequest(() -> {
+        if (!insidePopup) {
+          hidePopup();
+        }
+      }, Registry.intValue("ide.tooltip.initialDelay.highlighter"));
+    }
+
     private void showPopup(@NotNull InputEvent event) {
       hidePopup();
       if (myPopupState.isRecentlyHidden()) return; // do not show new popup
@@ -1981,7 +2029,7 @@ public final class EditorMarkupModelImpl extends MarkupModelImpl
         }
       }
 
-      if (Experiments.getInstance().isFeatureEnabled("problems.view.enabled")) {
+      if (!Experiments.getInstance().isFeatureEnabled("problems.view.enabled")) {
         JLabel openProblemsViewLabel = new TrackableLinkLabel(EditorBundle.message("iw.open.problems.view"), () -> {
           hidePopup();
           controller.openProblemsView();