From 53cf00af4d9bf1775bef992d39754edaff0c474b Mon Sep 17 00:00:00 2001 From: Maxim Shafirov Date: Thu, 20 Jan 2005 13:02:23 +0300 Subject: [PATCH] void methods should be ignored regardless the fact they match patterns defined. Otherwise String.getChars() method is being highlighted with default patterns. --- .../src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java index 75ed9ab114fa..871aa5145207 100644 --- a/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java +++ b/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java @@ -131,6 +131,11 @@ public class IgnoreResultOfCallInspection extends ExpressionInspection { return; } + final PsiType retType = method.getReturnType(); + if (retType == PsiType.VOID) { + return; + } + for (Iterator iterator = callsToCheck.iterator(); iterator.hasNext();) { final ReturnCheckSpecification spec = (ReturnCheckSpecification) iterator.next(); final Pattern methodNamePattern = spec.getMethodNamePattern();