From 515e504531d46e8c190efe135b3f3463c61b7bcb Mon Sep 17 00:00:00 2001 From: Ilya Klyuchnikov Date: Thu, 25 Sep 2014 16:58:44 +0400 Subject: [PATCH] bytecode analysis: this.someMethod() is not stable IDEA-129645 --- .../bytecodeAnalysis/NullableMethodAnalysis.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/bytecodeAnalysis/NullableMethodAnalysis.java b/java/java-analysis-impl/src/com/intellij/codeInspection/bytecodeAnalysis/NullableMethodAnalysis.java index cf2e8d7a1da4..6e0d822528c9 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/bytecodeAnalysis/NullableMethodAnalysis.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/bytecodeAnalysis/NullableMethodAnalysis.java @@ -337,9 +337,7 @@ class NullableMethodInterpreter extends BasicInterpreter implements InterpreterE case INVOKEVIRTUAL: int insnIndex = insns.indexOf(insn); if (origins[insnIndex]) { - boolean stable = (opCode == INVOKESTATIC) || - (opCode == INVOKESPECIAL) || - (values.get(0) == ThisValue); + boolean stable = opCode == INVOKESTATIC || opCode == INVOKESPECIAL; MethodInsnNode mNode = ((MethodInsnNode)insn); Method method = new Method(mNode.owner, mNode.name, mNode.desc); int label = 1 << originsMapping[insnIndex];