From 4ede656b144370970dc933a38dcd7cb2cffd0603 Mon Sep 17 00:00:00 2001
From: Sergey Evdokimov <sergey.evdokimov@jetbrains.com>
Date: Wed, 18 Apr 2012 18:52:07 +0400
Subject: [PATCH] IDEA-84800 strange and unhelpful "value must not be empty" in
 the pom.xml

---
 .../maven/dom/MavenPluginConfigurationDomExtender.java    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/MavenPluginConfigurationDomExtender.java b/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/MavenPluginConfigurationDomExtender.java
index 54a34342c885..7656fc318d48 100644
--- a/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/MavenPluginConfigurationDomExtender.java
+++ b/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/MavenPluginConfigurationDomExtender.java
@@ -191,16 +191,18 @@ public class MavenPluginConfigurationDomExtender extends DomExtender<MavenDomCon
   }
 
   private static void addRequiredAnnotation(DomExtension e, final ParameterData data) {
-    if (Boolean.parseBoolean(data.parameter.getRequired().getStringValue())) {
+    if (Boolean.parseBoolean(data.parameter.getRequired().getStringValue())
+        && StringUtil.isEmptyOrSpaces(data.defaultValue)
+        && StringUtil.isEmptyOrSpaces(data.expression)) {
       e.addCustomAnnotation(new Required(){
         @Override
         public boolean value() {
-          return StringUtil.isEmptyOrSpaces(data.defaultValue) && StringUtil.isEmptyOrSpaces(data.expression);
+          return true;
         }
 
         @Override
         public boolean nonEmpty() {
-          return true;
+          return false;
         }
 
         @Override