From 4ccc72e919c2ddebaab75af72b9e9654c226b882 Mon Sep 17 00:00:00 2001
From: Konstantin Hudyakov <konstantin.hudyakov@jetbrains.com>
Date: Mon, 5 Aug 2024 12:53:20 +0300
Subject: [PATCH] [IFT] Do not allow opening reworked onboarding tour until
 indexing is finished

Move properties override to project-based onboarding lesson base class.
Probably will make the problems described in IFT-591 and IFT-592 appear less often.

GitOrigin-RevId: fa8ad0874ba30ef3b38fb719ef3fcc7a27159fa7
---
 .../ift/lesson/essential/CommonLogicForOnboardingTours.kt   | 5 -----
 .../java/ift/lesson/essential/OnboardingTourLessonBase.kt   | 6 ++++++
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/CommonLogicForOnboardingTours.kt b/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/CommonLogicForOnboardingTours.kt
index dd5cf90f3d3d..0b72de7836c7 100644
--- a/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/CommonLogicForOnboardingTours.kt
+++ b/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/CommonLogicForOnboardingTours.kt
@@ -76,11 +76,6 @@ abstract class CommonLogicForOnboardingTours(id: String, @Nls lessonName: String
   @NlsSafe
   private var jdkAtStart: String = "undefined"
 
-  override val properties: LessonProperties = LessonProperties(
-    canStartInDumbMode = true,
-    openFileAtStart = false
-  )
-
   override val testScriptProperties: TaskTestContext.TestScriptProperties = TaskTestContext.TestScriptProperties(skipTesting = true)
 
   open fun TaskRuntimeContext.rememberJdkAtStart() {
diff --git a/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/OnboardingTourLessonBase.kt b/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/OnboardingTourLessonBase.kt
index 0b765e2871b1..30f153d340c8 100644
--- a/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/OnboardingTourLessonBase.kt
+++ b/java/java-features-trainer/src/com/intellij/java/ift/lesson/essential/OnboardingTourLessonBase.kt
@@ -17,6 +17,7 @@ import training.dsl.*
 import training.dsl.LessonUtil.restoreIfModified
 import training.learn.LearnBundle
 import training.learn.NewUsersOnboardingExperimentAccessor
+import training.learn.course.LessonProperties
 import training.learn.course.LessonType
 import training.learn.lesson.general.run.clearBreakpoints
 import training.project.ProjectUtils
@@ -29,6 +30,11 @@ import javax.swing.tree.TreePath
 abstract class OnboardingTourLessonBase(id: String) : CommonLogicForOnboardingTours(id, JavaLessonsBundle.message("java.onboarding.lesson.name")) {
   override val lessonType: LessonType = LessonType.PROJECT
 
+  override val properties: LessonProperties = LessonProperties(
+    canStartInDumbMode = true,
+    openFileAtStart = false
+  )
+
   private lateinit var openLearnTaskId: TaskContext.TaskId
 
   private val demoFileDirectory: String = "src"