From 4c85a4c8b41c1a07ec8882bcef4a5f6c2cfa9c5e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Yann=20C=C3=A9bron?= <yann.cebron@jetbrains.com>
Date: Tue, 16 Apr 2019 15:14:13 +0200
Subject: [PATCH] IDEA-211131 Bundled plugins: highlight generic <idea-plugin>
 "url" values

---
 .../org/jetbrains/idea/devkit/DevKitBundle.properties    | 1 +
 .../src/inspections/PluginXmlDomInspection.java          | 9 +++++++++
 .../testData/codeInsight/pluginWithJetBrainsAsVendor.xml | 3 ++-
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/plugins/devkit/devkit-core/resources/org/jetbrains/idea/devkit/DevKitBundle.properties b/plugins/devkit/devkit-core/resources/org/jetbrains/idea/devkit/DevKitBundle.properties
index 1840ff4c3b2f..b42887c6057f 100644
--- a/plugins/devkit/devkit-core/resources/org/jetbrains/idea/devkit/DevKitBundle.properties
+++ b/plugins/devkit/devkit-core/resources/org/jetbrains/idea/devkit/DevKitBundle.properties
@@ -149,6 +149,7 @@ inspections.plugin.xml.plugin.should.have.jetbrains.vendor=Plugin developed as a
 inspections.plugin.xml.plugin.should.include.jetbrains.vendor=Plugin developed as a part of IntelliJ IDEA project should include 'JetBrains' as one of its vendors
 inspections.plugin.xml.plugin.jetbrains.vendor.no.url=Plugin developed as a part of IntelliJ IDEA project shouldn''t specify ''{0}'' as url
 inspections.plugin.xml.plugin.jetbrains.vendor.no.email=Plugin developed as a part of IntelliJ IDEA project shouldn't specify email
+inspections.plugin.xml.plugin.jetbrains.no.generic.plugin.url=Plugin developed as a part of IntelliJ IDEA project shouldn't specify generic plugin url
 inspections.plugin.xml.ep.doesnt.have.with=<extensionPoint> does not have <with> tags to specify the types of class fields
 inspections.plugin.xml.ep.both.beanClass.and.interface=<extensionPoint> must not specify both 'interface' and 'beanClass' attributes
 inspections.plugin.xml.ep.missing.beanClass.and.interface=<extensionPoint> must specify either 'interface' or 'beanClass' attribute
diff --git a/plugins/devkit/devkit-core/src/inspections/PluginXmlDomInspection.java b/plugins/devkit/devkit-core/src/inspections/PluginXmlDomInspection.java
index 6334d809ce61..0c39bc7ae35a 100644
--- a/plugins/devkit/devkit-core/src/inspections/PluginXmlDomInspection.java
+++ b/plugins/devkit/devkit-core/src/inspections/PluginXmlDomInspection.java
@@ -280,6 +280,15 @@ public class PluginXmlDomInspection extends BasicDomElementsInspection<IdeaPlugi
   private static void checkJetBrainsPlugin(IdeaPlugin ideaPlugin, DomElementAnnotationHolder holder, @NotNull Module module) {
     if (!PsiUtil.isIdeaProject(module.getProject())) return;
 
+    if (DomUtil.hasXml(ideaPlugin.getUrl())) {
+      String url = ideaPlugin.getUrl().getStringValue();
+      if ("https://www.jetbrains.com/idea".equals(url)) {
+        holder.createProblem(ideaPlugin.getUrl(),
+                             DevKitBundle.message("inspections.plugin.xml.plugin.jetbrains.no.generic.plugin.url"),
+                             new RemoveDomElementQuickFix(ideaPlugin.getUrl())).highlightWholeElement();
+      }
+    }
+
     if (!hasRealPluginId(ideaPlugin)) return;
 
     String id = ideaPlugin.getId().getStringValue();
diff --git a/plugins/devkit/devkit-java-tests/testData/codeInsight/pluginWithJetBrainsAsVendor.xml b/plugins/devkit/devkit-java-tests/testData/codeInsight/pluginWithJetBrainsAsVendor.xml
index 46408902f8c9..e0be47a09d94 100644
--- a/plugins/devkit/devkit-java-tests/testData/codeInsight/pluginWithJetBrainsAsVendor.xml
+++ b/plugins/devkit/devkit-java-tests/testData/codeInsight/pluginWithJetBrainsAsVendor.xml
@@ -1,4 +1,5 @@
-<idea-plugin>
+<idea-plugin
+  <error descr="Plugin developed as a part of IntelliJ IDEA project shouldn't specify generic plugin url">url="https://www.jetbrains.com/idea"</error>>
   <id>test</id>
   <version>1.0</version>
   <vendor <error descr="Plugin developed as a part of IntelliJ IDEA project shouldn't specify 'http://www.jetbrains.com' as url">url="http://www.jetbrains.com"</error>