From 4c78f82283bde04776631be7a8bb020e09b76efa Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Tue, 19 Apr 2011 14:51:07 +0200 Subject: [PATCH] IDEA-68354 ('Mismatched query and update of StringBuilder' false positive) --- .../bugs/MismatchedStringBuilderQueryUpdateInspection.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/MismatchedStringBuilderQueryUpdateInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/MismatchedStringBuilderQueryUpdateInspection.java index 5cd627952100..e4bca75275d8 100644 --- a/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/MismatchedStringBuilderQueryUpdateInspection.java +++ b/plugins/InspectionGadgets/src/com/siyeh/ig/bugs/MismatchedStringBuilderQueryUpdateInspection.java @@ -30,7 +30,8 @@ import org.jetbrains.annotations.NotNull; import java.util.HashSet; import java.util.Set; -public class MismatchedStringBuilderQueryUpdateInspection extends BaseInspection { +public class MismatchedStringBuilderQueryUpdateInspection + extends BaseInspection { @NonNls private static final Set returnSelfNames = new HashSet(); @@ -150,6 +151,10 @@ public class MismatchedStringBuilderQueryUpdateInspection extends BaseInspection if(VariableAccessUtils.variableIsReturned(variable, context)){ return false; } + if (VariableAccessUtils.variableIsPassedAsMethodArgument(variable, + context)) { + return false; + } return !VariableAccessUtils.variableIsUsedInArrayInitializer( variable, context); }