From 49f87dc5fb6c1eef72edbdd54363b68e7b9dfb8f Mon Sep 17 00:00:00 2001 From: Alexey Pegov Date: Thu, 4 Feb 2010 16:13:31 +0300 Subject: [PATCH] Revert "IDEADEV-41762 Run Configurations: Replace Working directory textfield with combobox with $MODULE_DIR$ macro predefined" This reverts commit 7eeede6bb48fadadca3bc690858aed8b66a5689e. --- .../configuration/CommonJavaParameters.form | 22 ++++++++++++------- .../configuration/CommonJavaParameters.java | 19 ++++------------ 2 files changed, 18 insertions(+), 23 deletions(-) diff --git a/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.form b/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.form index bae06d286ce1..f669e9c28087 100644 --- a/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.form +++ b/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.form @@ -1,16 +1,18 @@
- + - + + - + + @@ -22,7 +24,8 @@ - + + @@ -32,13 +35,16 @@ - + - + + + + - - + + diff --git a/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.java b/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.java index 8615546035bb..f3b7a1c991bd 100644 --- a/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.java +++ b/java/execution/impl/src/com/intellij/execution/junit2/configuration/CommonJavaParameters.java @@ -26,7 +26,6 @@ import com.intellij.openapi.module.Module; import com.intellij.openapi.ui.LabeledComponent; import com.intellij.openapi.ui.TextFieldWithBrowseButton; import com.intellij.openapi.vfs.VirtualFile; -import com.intellij.ui.ComboboxWithBrowseButton; import com.intellij.ui.RawCommandLineEditor; import javax.swing.*; @@ -43,9 +42,9 @@ public class CommonJavaParameters extends JPanel { }; private JPanel myWholePanel; + private LabeledComponent myWorkingDirectory; private LabeledComponent myProgramParameters; private LabeledComponent myVMParameters; - private LabeledComponent myWorkingDirectoryCombo; private final LabeledComponent[] myFields = new LabeledComponent[3]; private Module myModule = null; @@ -55,27 +54,21 @@ public class CommonJavaParameters extends JPanel { add(myWholePanel, BorderLayout.CENTER); copyDialogCaption(myProgramParameters); copyDialogCaption(myVMParameters); - - final JComboBox comboBox = myWorkingDirectoryCombo.getComponent().getChildComponent(); - comboBox.setEditable(true); - comboBox.setModel(new DefaultComboBoxModel(new String[] {"$MODULE_DIR$"})); - - myWorkingDirectoryCombo.getComponent() + myWorkingDirectory.getComponent() .addActionListener(new ActionListener() { public void actionPerformed(ActionEvent e) { FileChooserDescriptor fileChooserDescriptor = FileChooserDescriptorFactory.createSingleFolderDescriptor(); fileChooserDescriptor.setTitle(ExecutionBundle.message("select.working.directory.message")); fileChooserDescriptor.putUserData(LangDataKeys.MODULE_CONTEXT, myModule); - VirtualFile[] files = FileChooser.chooseFiles(myWorkingDirectoryCombo, fileChooserDescriptor); + VirtualFile[] files = FileChooser.chooseFiles(myWorkingDirectory, fileChooserDescriptor); if (files.length != 0) { setText(RunJavaConfiguration.WORKING_DIRECTORY_PROPERTY, files[0].getPresentableUrl()); } } }); - myFields[RunJavaConfiguration.PROGRAM_PARAMETERS_PROPERTY] = myProgramParameters; myFields[RunJavaConfiguration.VM_PARAMETERS_PROPERTY] = myVMParameters; - myFields[RunJavaConfiguration.WORKING_DIRECTORY_PROPERTY] = myWorkingDirectoryCombo; + myFields[RunJavaConfiguration.WORKING_DIRECTORY_PROPERTY] = myWorkingDirectory; } private static void copyDialogCaption(final LabeledComponent component) { @@ -111,8 +104,6 @@ public class CommonJavaParameters extends JPanel { ((TextFieldWithBrowseButton)component).setText(value); else if (component instanceof RawCommandLineEditor) ((RawCommandLineEditor)component).setText(value); - else if (component instanceof ComboboxWithBrowseButton) - ((ComboboxWithBrowseButton)component).getChildComponent().setSelectedItem(value); else LOG.error(component.getClass().getName()); } @@ -122,8 +113,6 @@ public class CommonJavaParameters extends JPanel { return ((TextFieldWithBrowseButton)component).getText(); else if (component instanceof RawCommandLineEditor) return ((RawCommandLineEditor)component).getText(); - else if (component instanceof ComboboxWithBrowseButton) - return (String) ((ComboboxWithBrowseButton)component).getComboBox().getSelectedItem(); else LOG.error(component.getClass().getName()); return ""; }