From 47e2c8c0bc604b981bdda1f0d8ebdaed0b3c69f6 Mon Sep 17 00:00:00 2001 From: Petr Date: Tue, 15 Oct 2024 18:06:16 +0200 Subject: [PATCH] PY-75537 Slightly simplified PyAssignmentStatementImpl.getTargetsToValuesMapping() GitOrigin-RevId: 41f02b5c164380ad978cfa66eb36bb5b97189855 --- .../python/psi/impl/PyAssignmentStatementImpl.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyAssignmentStatementImpl.java b/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyAssignmentStatementImpl.java index 30e8b4d366d6..1b9ca3fbc308 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyAssignmentStatementImpl.java +++ b/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyAssignmentStatementImpl.java @@ -51,10 +51,11 @@ public class PyAssignmentStatementImpl extends PyElementImpl implements PyAssign if (!PsiTreeUtil.hasErrorElements(this)) { // no parse errors PyExpression[] constituents = PsiTreeUtil.getChildrenOfType(this, PyExpression.class); // "a = b = c" -> [a, b, c] if (constituents != null && constituents.length > 1) { - PyExpression rhs = constituents[constituents.length - 1]; // last - List lhses = Lists.newArrayList(constituents); - if (!lhses.isEmpty()) lhses.remove(lhses.size() - 1); // copy all but last; most often it's one element. - for (PyExpression lhs : lhses) mapToValues(lhs, rhs, ret); + int lastIndex = constituents.length - 1; + PyExpression rhs = constituents[lastIndex]; + for (int i = 0; i < lastIndex; i++) { + mapToValues(constituents[i], rhs, ret); + } } } return ret;