From 47d19319593bf3193df9fe4d6b5c1580b3168e88 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Yann=20C=C3=A9bron?= <yann.cebron@jetbrains.com>
Date: Tue, 10 Dec 2024 10:30:26 +0100
Subject: [PATCH] [devkit] set default level=ERROR for all description
 inspections (IJPL-173322)

GitOrigin-RevId: e6aa39b0fb4f17e689aff81a4914d9b14059b113
---
 .../devkit/devkit-core/resources/intellij.devkit.core.xml   | 6 +++---
 .../inspections/inspectionDescription/MyInspection.java     | 2 +-
 .../inspectionDescription/MyInspectionCustomShortName.java  | 2 +-
 .../inspectionDescription/MyRegisteredInspection.java       | 2 +-
 .../MyWithDescriptionAndShortNameInBaseInspection.java      | 2 +-
 .../inspections/intentionDescription/MyIntentionAction.java | 2 +-
 .../MyIntentionActionWithoutBeforeAfter.java                | 2 +-
 .../testData/inspections/postfixTemplates/MyTemplate.java   | 2 +-
 .../postfixTemplates/MyTemplateWithoutBeforeAfter.java      | 2 +-
 .../inspections/inspectionDescription/MyInspection.kt       | 2 +-
 .../inspectionDescription/MyInspectionCustomShortName.kt    | 2 +-
 11 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/plugins/devkit/devkit-core/resources/intellij.devkit.core.xml b/plugins/devkit/devkit-core/resources/intellij.devkit.core.xml
index 865c6c7abc4d..0d4f2be9431c 100644
--- a/plugins/devkit/devkit-core/resources/intellij.devkit.core.xml
+++ b/plugins/devkit/devkit-core/resources/intellij.devkit.core.xml
@@ -152,7 +152,7 @@
     <localInspection language="JVM" shortName="InspectionDescriptionNotFoundInspection"
                      projectType="INTELLIJ_PLUGIN"
                      groupPathKey="inspections.group.path" groupKey="inspections.group.description.file"
-                     enabledByDefault="true" level="WARNING"
+                     enabledByDefault="true" level="ERROR"
                      implementationClass="org.jetbrains.idea.devkit.inspections.InspectionDescriptionNotFoundInspection"
                      key="inspection.inspection.description.not.found.inspection.display.name"/>
     <localInspection language="JVM" shortName="checkReturnValue"
@@ -176,7 +176,7 @@
     <localInspection language="JVM" shortName="IntentionDescriptionNotFoundInspection"
                      projectType="INTELLIJ_PLUGIN"
                      groupPathKey="inspections.group.path" groupKey="inspections.group.description.file"
-                     enabledByDefault="true" level="WARNING"
+                     enabledByDefault="true" level="ERROR"
                      implementationClass="org.jetbrains.idea.devkit.inspections.IntentionDescriptionNotFoundInspection"
                      key="inspection.intention.description.not.found.inspection.display.name"/>
     <localInspection language="JVM"
@@ -184,7 +184,7 @@
                      key="inspections.component.postfix.template.not.found.description.name"
                      groupPathKey="inspections.group.path" groupKey="inspections.group.description.file"
                      enabledByDefault="true"
-                     level="WARNING"
+                     level="ERROR"
                      implementationClass="org.jetbrains.idea.devkit.inspections.PostfixTemplateDescriptionNotFoundInspection"/>
     <!--suppress PluginXmlCapitalization -->
     <localInspection language="UAST" shortName="ComponentRegistrationProblems"
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspection.java b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspection.java
index cca7d33b99e1..2552eff6b4d9 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspection.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspection.java
@@ -1,3 +1,3 @@
 import com.intellij.codeInspection.InspectionProfileEntry;
 
-public class <warning descr="Inspection does not have a description">MyInspection</warning> extends InspectionProfileEntry {}
\ No newline at end of file
+public class <error descr="Inspection does not have a description">MyInspection</error> extends InspectionProfileEntry {}
\ No newline at end of file
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.java b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.java
index cebc4c10ac11..0264cd38122d 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.java
@@ -1,6 +1,6 @@
 import com.intellij.codeInspection.InspectionProfileEntry;
 
-public class <warning descr="Inspection does not have a description [getShortName()]">MyInspectionCustomShortName</warning> extends InspectionProfileEntry {
+public class <error descr="Inspection does not have a description [getShortName()]">MyInspectionCustomShortName</error> extends InspectionProfileEntry {
 
   public String getShortName() {
     return "NOT_EXISTING_CUSTOM_SHORT_NAME";
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyRegisteredInspection.java b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyRegisteredInspection.java
index 0efd5d656d02..1ebbd7031577 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyRegisteredInspection.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyRegisteredInspection.java
@@ -1,4 +1,4 @@
 import com.intellij.codeInspection.InspectionProfileEntry;
 
-public class <warning descr="Inspection does not have a description">MyRegisteredInspection</warning> extends InspectionProfileEntry {
+public class <error descr="Inspection does not have a description">MyRegisteredInspection</error> extends InspectionProfileEntry {
 }
\ No newline at end of file
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyWithDescriptionAndShortNameInBaseInspection.java b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyWithDescriptionAndShortNameInBaseInspection.java
index 5cee6f6e2d09..2bba4cc83d1b 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyWithDescriptionAndShortNameInBaseInspection.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/inspectionDescription/MyWithDescriptionAndShortNameInBaseInspection.java
@@ -8,4 +8,4 @@ class ALocalInspectionTool extends LocalInspectionTool {
     return com.intellij.codeInspection.InspectionProfileEntry.getShortName(name);
   }
 }
-public class <warning descr="Inspection does not have a description [getShortName()]">MyWithDescriptionAndShortNameInBaseInspection</warning> extends ALocalInspectionTool {}
\ No newline at end of file
+public class <error descr="Inspection does not have a description [getShortName()]">MyWithDescriptionAndShortNameInBaseInspection</error> extends ALocalInspectionTool {}
\ No newline at end of file
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionAction.java b/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionAction.java
index d40ef87d1148..66e1a5b2e4b4 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionAction.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionAction.java
@@ -4,7 +4,7 @@ import com.intellij.openapi.util.Iconable;
 import com.intellij.psi.PsiFile;
 import com.intellij.util.IncorrectOperationException;
 
-public class <warning descr="Intention does not have a description">MyIntentionAction</warning> implements com.intellij.codeInsight.intention.IntentionAction {
+public class <error descr="Intention does not have a description">MyIntentionAction</error> implements com.intellij.codeInsight.intention.IntentionAction {
 
   public String getText() { return"text"; }
   public String getFamilyName() { return"familyName"; }
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionActionWithoutBeforeAfter.java b/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionActionWithoutBeforeAfter.java
index dc80bd0df20d..0f38befd576b 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionActionWithoutBeforeAfter.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/intentionDescription/MyIntentionActionWithoutBeforeAfter.java
@@ -4,7 +4,7 @@ import com.intellij.openapi.util.Iconable;
 import com.intellij.psi.PsiFile;
 import com.intellij.util.IncorrectOperationException;
 
-public class <warning descr="Intention must have 'before.*.template' and 'after.*.template' beside 'description.html'">MyIntentionActionWithoutBeforeAfter</warning> implements com.intellij.codeInsight.intention.IntentionAction {
+public class <error descr="Intention must have 'before.*.template' and 'after.*.template' beside 'description.html'">MyIntentionActionWithoutBeforeAfter</error> implements com.intellij.codeInsight.intention.IntentionAction {
 
   public String getText() { return"text"; }
   public String getFamilyName() { return"familyName"; }
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplate.java b/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplate.java
index e20fbb6be2df..31320df9737c 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplate.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplate.java
@@ -1,6 +1,6 @@
 import com.intellij.codeInsight.template.postfix.templates.PostfixTemplate;
 
-public class <warning descr="Postfix template does not have a description">MyTemplate</warning> extends PostfixTemplate  {
+public class <error descr="Postfix template does not have a description">MyTemplate</error> extends PostfixTemplate  {
 
 
 }
diff --git a/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplateWithoutBeforeAfter.java b/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplateWithoutBeforeAfter.java
index 9e0ae10e8905..0564c8c2d313 100644
--- a/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplateWithoutBeforeAfter.java
+++ b/plugins/devkit/devkit-java-tests/testData/inspections/postfixTemplates/MyTemplateWithoutBeforeAfter.java
@@ -1,6 +1,6 @@
 import com.intellij.codeInsight.template.postfix.templates.PostfixTemplate;
 
-public class <warning descr="Postfix template must have 'before.*.template' and 'after.*.template' beside 'description.html'">MyTemplateWithoutBeforeAfter</warning> extends PostfixTemplate{
+public class <error descr="Postfix template must have 'before.*.template' and 'after.*.template' beside 'description.html'">MyTemplateWithoutBeforeAfter</error> extends PostfixTemplate{
 
 
   }
diff --git a/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspection.kt b/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspection.kt
index 7db8e5f178a7..843ff055f704 100644
--- a/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspection.kt
+++ b/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspection.kt
@@ -1,3 +1,3 @@
-class <warning descr="Inspection does not have a description">MyInspection</warning> : com.intellij.codeInspection.InspectionProfileEntry() {
+class <error descr="Inspection does not have a description">MyInspection</error> : com.intellij.codeInspection.InspectionProfileEntry() {
   
 }
diff --git a/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.kt b/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.kt
index 1cc88bbfaddb..2c696dba1e8f 100644
--- a/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.kt
+++ b/plugins/devkit/devkit-kotlin-tests/testData/inspections/inspectionDescription/MyInspectionCustomShortName.kt
@@ -1,4 +1,4 @@
-class <warning descr="Inspection does not have a description [getShortName()]">MyInspectionCustomShortName</warning> : com.intellij.codeInspection.InspectionProfileEntry() {
+class <error descr="Inspection does not have a description [getShortName()]">MyInspectionCustomShortName</error> : com.intellij.codeInspection.InspectionProfileEntry() {
   override fun getShortName(): String {
     return "NOT_EXISTING_CUSTOM_SHORT_NAME"
   }