From 461d220ace6d68f59965a103b8bcfb50f5b8e356 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Fri, 8 Nov 2024 11:53:10 +0100 Subject: [PATCH] [java-inspections] MismatchedCollectionQueryUpdateInspection: assume a collection as non-empty if its constructor accepts iterator GitOrigin-RevId: 2d381e8ae775efa7cbe621aa185766fa74abcc6f --- .../ig/bugs/MismatchedCollectionQueryUpdateInspection.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/java/java-impl/src/com/siyeh/ig/bugs/MismatchedCollectionQueryUpdateInspection.java b/java/java-impl/src/com/siyeh/ig/bugs/MismatchedCollectionQueryUpdateInspection.java index 7ab294a0a61f..3f1a59a2cc6a 100644 --- a/java/java-impl/src/com/siyeh/ig/bugs/MismatchedCollectionQueryUpdateInspection.java +++ b/java/java-impl/src/com/siyeh/ig/bugs/MismatchedCollectionQueryUpdateInspection.java @@ -506,6 +506,9 @@ public final class MismatchedCollectionQueryUpdateInspection extends BaseInspect if (CollectionUtils.isCollectionClassOrInterface(type)) { return false; } + if (InheritanceUtil.isInheritor(type, CommonClassNames.JAVA_UTIL_ITERATOR)) { + return false; + } if (type instanceof PsiArrayType && !(type instanceof PsiEllipsisType)) { return false; }