From 443d443bb7c672ef2dc0f0d9108ffa2bb9756e06 Mon Sep 17 00:00:00 2001
From: peter <peter@jetbrains.com>
Date: Mon, 21 Nov 2016 09:57:08 +0100
Subject: [PATCH] assert that vfile rename/move/delete should happen in a write
 action

---
 .../core-api/src/com/intellij/openapi/vfs/VirtualFile.java | 4 ++++
 .../openapi/vfs/newvfs/impl/VirtualFileSystemEntry.java    | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/platform/core-api/src/com/intellij/openapi/vfs/VirtualFile.java b/platform/core-api/src/com/intellij/openapi/vfs/VirtualFile.java
index 7a2becb934b1..42f45e775257 100644
--- a/platform/core-api/src/com/intellij/openapi/vfs/VirtualFile.java
+++ b/platform/core-api/src/com/intellij/openapi/vfs/VirtualFile.java
@@ -208,6 +208,7 @@ public abstract class VirtualFile extends UserDataHolderBase implements Modifica
    * @throws IOException if file failed to be renamed
    */
   public void rename(Object requestor, @NotNull String newName) throws IOException {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
     if (getName().equals(newName)) return;
     if (!getFileSystem().isValidName(newName)) {
       throw new IOException(VfsBundle.message("file.invalid.name.error", newName));
@@ -451,6 +452,7 @@ public abstract class VirtualFile extends UserDataHolderBase implements Modifica
    * @throws IOException if file failed to be deleted
    */
   public void delete(Object requestor) throws IOException {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
     LOG.assertTrue(isValid(), "Deleting invalid file");
     getFileSystem().deleteFile(requestor, this);
   }
@@ -466,6 +468,8 @@ public abstract class VirtualFile extends UserDataHolderBase implements Modifica
    * @throws IOException if file failed to be moved
    */
   public void move(final Object requestor, @NotNull final VirtualFile newParent) throws IOException {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
+
     if (getFileSystem() != newParent.getFileSystem()) {
       throw new IOException(VfsBundle.message("file.move.error", newParent.getPresentableUrl()));
     }
diff --git a/platform/platform-impl/src/com/intellij/openapi/vfs/newvfs/impl/VirtualFileSystemEntry.java b/platform/platform-impl/src/com/intellij/openapi/vfs/newvfs/impl/VirtualFileSystemEntry.java
index 4c792fcd7070..ecbaf4637d5e 100644
--- a/platform/platform-impl/src/com/intellij/openapi/vfs/newvfs/impl/VirtualFileSystemEntry.java
+++ b/platform/platform-impl/src/com/intellij/openapi/vfs/newvfs/impl/VirtualFileSystemEntry.java
@@ -16,6 +16,7 @@
 package com.intellij.openapi.vfs.newvfs.impl;
 
 import com.intellij.ide.ui.UISettings;
+import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.fileEditor.impl.LoadTextUtil;
 import com.intellij.openapi.util.Key;
 import com.intellij.openapi.util.io.FileTooBigException;
@@ -201,11 +202,13 @@ public abstract class VirtualFileSystemEntry extends NewVirtualFile {
 
   @Override
   public void delete(final Object requestor) throws IOException {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
     ourPersistence.deleteFile(requestor, this);
   }
 
   @Override
   public void rename(final Object requestor, @NotNull @NonNls final String newName) throws IOException {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
     if (getName().equals(newName)) return;
     validateName(newName);
     ourPersistence.renameFile(requestor, this, newName);
@@ -258,6 +261,8 @@ public abstract class VirtualFileSystemEntry extends NewVirtualFile {
 
   @Override
   public void move(final Object requestor, @NotNull final VirtualFile newParent) throws IOException {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
+
     if (getFileSystem() != newParent.getFileSystem()) {
       throw new IOException(VfsBundle.message("file.move.error", newParent.getPresentableUrl()));
     }
@@ -323,6 +328,8 @@ public abstract class VirtualFileSystemEntry extends NewVirtualFile {
   }
 
   public void setParent(@NotNull VirtualFile newParent) {
+    ApplicationManager.getApplication().assertWriteAccessAllowed();
+
     VirtualDirectoryImpl parent = getParent();
     parent.removeChild(this);