From 4438cf9bced78ee825920cce2c49e742d8382a76 Mon Sep 17 00:00:00 2001 From: "Vladislav.Soroka" Date: Thu, 16 Apr 2015 15:41:11 +0300 Subject: [PATCH] maven: manifest serialization/deserialization to/from xml fix --- .../MavenCommonArtifactRootCopyingHandlerProvider.java | 3 +-- .../project/MavenResourceCompilerConfigurationGenerator.java | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/maven/jps-plugin/src/org/jetbrains/jps/maven/compiler/MavenCommonArtifactRootCopyingHandlerProvider.java b/plugins/maven/jps-plugin/src/org/jetbrains/jps/maven/compiler/MavenCommonArtifactRootCopyingHandlerProvider.java index 65973a4856f4..57a561be54ec 100644 --- a/plugins/maven/jps-plugin/src/org/jetbrains/jps/maven/compiler/MavenCommonArtifactRootCopyingHandlerProvider.java +++ b/plugins/maven/jps-plugin/src/org/jetbrains/jps/maven/compiler/MavenCommonArtifactRootCopyingHandlerProvider.java @@ -59,8 +59,7 @@ public class MavenCommonArtifactRootCopyingHandlerProvider extends ArtifactRootC projectConfiguration.moduleConfigurations.get(getModuleName(artifact.getName())); if (moduleResourceConfiguration != null && moduleResourceConfiguration.manifest != null) { try { - final String manifest = new String(Base64.decode(moduleResourceConfiguration.manifest)); - FileUtil.writeToFile(root, manifest); + FileUtil.writeToFile(root, Base64.decode(moduleResourceConfiguration.manifest)); } catch (IOException e) { LOG.debug(e); diff --git a/plugins/maven/src/main/java/org/jetbrains/idea/maven/project/MavenResourceCompilerConfigurationGenerator.java b/plugins/maven/src/main/java/org/jetbrains/idea/maven/project/MavenResourceCompilerConfigurationGenerator.java index 85b1cb0aa4e7..795aac27c5a7 100644 --- a/plugins/maven/src/main/java/org/jetbrains/idea/maven/project/MavenResourceCompilerConfigurationGenerator.java +++ b/plugins/maven/src/main/java/org/jetbrains/idea/maven/project/MavenResourceCompilerConfigurationGenerator.java @@ -14,6 +14,7 @@ import com.intellij.openapi.util.JDOMUtil; import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.util.io.StreamUtil; import com.intellij.openapi.util.text.StringUtil; +import com.intellij.openapi.vfs.CharsetToolkit; import com.intellij.openapi.vfs.LocalFileSystem; import com.intellij.openapi.vfs.VfsUtil; import com.intellij.openapi.vfs.VirtualFile; @@ -227,8 +228,8 @@ public class MavenResourceCompilerConfigurationGenerator { try { manifest.write(outputStream); MavenDomProjectModel domModel = MavenDomUtil.getMavenDomProjectModel(module.getProject(), mavenProject.getFile()); - final String resolvedText = MavenPropertyResolver.resolve(outputStream.toString("UTF8"), domModel); - resourceConfig.manifest = Base64.encode(resolvedText.getBytes("UTF8")); + final String resolvedText = MavenPropertyResolver.resolve(outputStream.toString(CharsetToolkit.UTF8), domModel); + resourceConfig.manifest = Base64.encode(resolvedText.getBytes(CharsetToolkit.UTF8)); } finally { StreamUtil.closeStream(outputStream);