From 43f9491a1038f7da8ae2d008afea0786697616ef Mon Sep 17 00:00:00 2001 From: Dmitry Avdeev Date: Sun, 12 Mar 2023 16:07:08 +0100 Subject: [PATCH] do not use PsiElement for popup model GitOrigin-RevId: 81fa1be6e48a5194d5eceaa54a8f2c6298b892a3 --- .../src/com/intellij/ui/popup/PopupFactoryImpl.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/platform/platform-impl/src/com/intellij/ui/popup/PopupFactoryImpl.java b/platform/platform-impl/src/com/intellij/ui/popup/PopupFactoryImpl.java index dc9b4585fd13..1c014a1ab4f0 100644 --- a/platform/platform-impl/src/com/intellij/ui/popup/PopupFactoryImpl.java +++ b/platform/platform-impl/src/com/intellij/ui/popup/PopupFactoryImpl.java @@ -26,6 +26,7 @@ import com.intellij.openapi.util.*; import com.intellij.openapi.util.NlsContexts.PopupTitle; import com.intellij.openapi.util.text.TextWithMnemonic; import com.intellij.openapi.wm.WindowManager; +import com.intellij.psi.PsiElement; import com.intellij.ui.*; import com.intellij.ui.awt.RelativePoint; import com.intellij.ui.components.JBList; @@ -79,6 +80,8 @@ public class PopupFactoryImpl extends JBPopupFactory { @Override public @NotNull IPopupChooserBuilder createPopupChooserBuilder(@NotNull List list) { + LOG.assertTrue(list.isEmpty() || !(list.get(0) instanceof PsiElement) || ApplicationManager.getApplication().isUnitTestMode(), + "Do not use PsiElement for popup model. See PsiTargetNavigator"); JBList jbList = new JBList<>(new CollectionListModel<>(list)); PopupUtil.applyNewUIBackground(jbList); return new PopupChooserBuilder<>(jbList);