From 435147d6cd3a3d9a6509191a783a10f3d4a997e8 Mon Sep 17 00:00:00 2001
From: Sergey Simonchik <sergey.simonchik@jetbrains.com>
Date: Thu, 11 Oct 2018 13:23:40 +0300
Subject: [PATCH] terminal: allow tabs saving after tabs are restored
 (IDEA-CR-37863)

---
 .../terminal/TerminalArrangementManager.java     | 16 ++++++++--------
 .../terminal/TerminalToolWindowFactory.java      |  3 ++-
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalArrangementManager.java b/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalArrangementManager.java
index 22e8a7849f6c..deabaafc6d9f 100644
--- a/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalArrangementManager.java
+++ b/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalArrangementManager.java
@@ -12,7 +12,7 @@ import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 @State(name = "TerminalArrangementManager", storages = {
-  @Storage(StoragePathMacros.CACHE_FILE),
+  @Storage(StoragePathMacros.CACHE_FILE)
 })
 public class TerminalArrangementManager implements PersistentStateComponent<TerminalArrangementState> {
 
@@ -33,7 +33,11 @@ public class TerminalArrangementManager implements PersistentStateComponent<Term
   @Nullable
   @Override
   public TerminalArrangementState getState() {
-    return isAvailable() ? calcArrangementState() : null;
+    if (!isAvailable() || myTerminalToolWindow == null) {
+      // do not save state, reuse previously stored state
+      return null;
+    }
+    return calcArrangementState(myTerminalToolWindow);
   }
 
   @Override
@@ -49,13 +53,9 @@ public class TerminalArrangementManager implements PersistentStateComponent<Term
   }
 
   @NotNull
-  private TerminalArrangementState calcArrangementState() {
+  private TerminalArrangementState calcArrangementState(@NotNull ToolWindow terminalToolWindow) {
     TerminalArrangementState arrangementState = new TerminalArrangementState();
-    if (myTerminalToolWindow == null) {
-      LOG.warn("Unavailable " + TerminalToolWindowFactory.TOOL_WINDOW_ID + " toolwindow");
-      return arrangementState;
-    }
-    ContentManager contentManager = myTerminalToolWindow.getContentManager();
+    ContentManager contentManager = terminalToolWindow.getContentManager();
     for (Content content : contentManager.getContents()) {
       TerminalTabState tabState = new TerminalTabState();
       tabState.myTabName = content.getTabName();
diff --git a/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalToolWindowFactory.java b/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalToolWindowFactory.java
index f64ac45bab00..40ff3442395e 100644
--- a/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalToolWindowFactory.java
+++ b/plugins/terminal/src/org/jetbrains/plugins/terminal/TerminalToolWindowFactory.java
@@ -31,7 +31,8 @@ public class TerminalToolWindowFactory implements ToolWindowFactory, DumbAware {
   public void createToolWindowContent(@NotNull Project project, @NotNull ToolWindow toolWindow) {
     TerminalView terminalView = TerminalView.getInstance(project);
     TerminalArrangementManager arrangementManager = TerminalArrangementManager.getInstance(project);
-    arrangementManager.setToolWindow(toolWindow);
     terminalView.initTerminal(toolWindow, arrangementManager.getArrangementState());
+    // allow to save tabs after the tabs are restored
+    arrangementManager.setToolWindow(toolWindow);
   }
 }