From 43434ac2b48fae2e51f78ce8f4c1cff5155ea85a Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Thu, 7 Feb 2019 14:55:08 +0100 Subject: [PATCH] simplify testng assertions: as there is no Assert#assertArrayEquals, disable the suggestion (IDEA-194715) --- .../ig/testFrameworks/SimplifiableAssertionInspection.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/testFrameworks/SimplifiableAssertionInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/testFrameworks/SimplifiableAssertionInspection.java index 6070c523a41b..17057fdc7d1d 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/testFrameworks/SimplifiableAssertionInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/testFrameworks/SimplifiableAssertionInspection.java @@ -173,7 +173,7 @@ public abstract class SimplifiableAssertionInspection extends BaseInspection { else if (isEqualityComparison(position)) { replaceAssertLiteralWithAssertEquals(callExpression, position, assertTrueFalseHint.getMessage(), assertTrueFalseHint.getArgIndex(), "assertNotEquals"); } - else if (assertTrue && isArrayEqualityComparison(position)) { + else if (assertTrue && !checkTestNG() && isArrayEqualityComparison(position)) { replaceAssertLiteralWithAssertEquals(callExpression, position, assertTrueFalseHint.getMessage(), assertTrueFalseHint.getArgIndex(), "assertArrayEquals"); } else if (BoolUtils.isNegation(position)) { @@ -467,7 +467,7 @@ public abstract class SimplifiableAssertionInspection extends BaseInspection { else if (isAssertThatCouldBeFail(position, !assertTrue)) { registerMethodCallError(expression, "fail()"); } - else if (assertTrue && isArrayEqualityComparison(position)) { + else if (assertTrue && !checkTestNG() && isArrayEqualityComparison(position)) { registerMethodCallError(expression, "assertArrayEquals"); } else if (BoolUtils.isNegation(position)) {