From 4342b7f07256d7b5279754bd8757eddc42baae72 Mon Sep 17 00:00:00 2001 From: Ekaterina Tuzova Date: Thu, 28 Mar 2013 18:25:26 +0400 Subject: [PATCH] fixed target references in static method inspection --- .../python/inspections/PyMethodMayBeStaticInspection.java | 1 + .../PyMethodMayBeStaticInspection/withQualifier.py | 6 ++++++ .../inspections/PyMethodMayBeStaticInspectionTest.java | 4 ++++ 3 files changed, 11 insertions(+) create mode 100644 python/testData/inspections/PyMethodMayBeStaticInspection/withQualifier.py diff --git a/python/src/com/jetbrains/python/inspections/PyMethodMayBeStaticInspection.java b/python/src/com/jetbrains/python/inspections/PyMethodMayBeStaticInspection.java index 4482e44e4f75..4c67f1d0273b 100644 --- a/python/src/com/jetbrains/python/inspections/PyMethodMayBeStaticInspection.java +++ b/python/src/com/jetbrains/python/inspections/PyMethodMayBeStaticInspection.java @@ -57,6 +57,7 @@ public class PyMethodMayBeStaticInspection extends PyInspection { PyRecursiveElementVisitor visitor = new PyRecursiveElementVisitor() { @Override public void visitPyReferenceExpression(PyReferenceExpression node) { + super.visitPyReferenceExpression(node); if (PyNames.CANONICAL_SELF.equals(node.getName())) { mayBeStatic[0] = false; } diff --git a/python/testData/inspections/PyMethodMayBeStaticInspection/withQualifier.py b/python/testData/inspections/PyMethodMayBeStaticInspection/withQualifier.py new file mode 100644 index 000000000000..d8385a021fff --- /dev/null +++ b/python/testData/inspections/PyMethodMayBeStaticInspection/withQualifier.py @@ -0,0 +1,6 @@ +__author__ = 'ktisha' + +class Child(Base): + + def f(self): + print self.f() \ No newline at end of file diff --git a/python/testSrc/com/jetbrains/python/inspections/PyMethodMayBeStaticInspectionTest.java b/python/testSrc/com/jetbrains/python/inspections/PyMethodMayBeStaticInspectionTest.java index 4a198d7983a0..6ae50ebfe844 100644 --- a/python/testSrc/com/jetbrains/python/inspections/PyMethodMayBeStaticInspectionTest.java +++ b/python/testSrc/com/jetbrains/python/inspections/PyMethodMayBeStaticInspectionTest.java @@ -23,6 +23,10 @@ public class PyMethodMayBeStaticInspectionTest extends PyTestCase { doTest(); } + public void testWithQualifier() { + doTest(); + } + private void doTest() { myFixture.configureByFile("inspections/PyMethodMayBeStaticInspection/" + getTestName(true) + ".py"); myFixture.enableInspections(PyMethodMayBeStaticInspection.class);