From 42a268c908e845ed6ea696282a6e63df0aca70f5 Mon Sep 17 00:00:00 2001
From: "Anna.Kozlova" <anna.kozlova@jetbrains.com>
Date: Thu, 28 Dec 2017 14:56:42 +0100
Subject: [PATCH] goto: navigate in success case only (IDEA-182556)

---
 .../com/intellij/codeInsight/daemon/impl/MarkerType.java  | 8 ++++----
 .../codeInsight/navigation/GotoImplementationHandler.java | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/MarkerType.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/MarkerType.java
index 8ab81bbfd61f..fe243f10d376 100644
--- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/MarkerType.java
+++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/MarkerType.java
@@ -388,8 +388,8 @@ public class MarkerType {
     }
 
     @Override
-    public void onFinished() {
-      super.onFinished();
+    public void onSuccess() {
+      super.onSuccess();
       PsiElement oneElement = getTheOnlyOneElement();
       if (oneElement instanceof NavigatablePsiElement) {
         ((NavigatablePsiElement)oneElement).navigate(true);
@@ -445,8 +445,8 @@ public class MarkerType {
     }
 
     @Override
-    public void onFinished() {
-      super.onFinished();
+    public void onSuccess() {
+      super.onSuccess();
       PsiElement oneElement = getTheOnlyOneElement();
       if (oneElement instanceof NavigatablePsiElement) {
         ((NavigatablePsiElement)oneElement).navigate(true);
diff --git a/platform/lang-impl/src/com/intellij/codeInsight/navigation/GotoImplementationHandler.java b/platform/lang-impl/src/com/intellij/codeInsight/navigation/GotoImplementationHandler.java
index cdd097ffb572..ed1863013c82 100644
--- a/platform/lang-impl/src/com/intellij/codeInsight/navigation/GotoImplementationHandler.java
+++ b/platform/lang-impl/src/com/intellij/codeInsight/navigation/GotoImplementationHandler.java
@@ -71,8 +71,8 @@ public class GotoImplementationHandler extends GotoTargetHandler {
     GotoData gotoData = new GotoData(source, targets, Collections.emptyList());
     gotoData.listUpdaterTask = new ImplementationsUpdaterTask(gotoData, editor, offset, reference) {
       @Override
-      public void onFinished() {
-        super.onFinished();
+      public void onSuccess() {
+        super.onSuccess();
         PsiElement oneElement = getTheOnlyOneElement();
         if (oneElement != null && navigateToElement(oneElement)) {
           myPopup.cancel();